revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Fixed Differential quotes rendering. (phabricator)

Browse source 
Summary:
When quoting someone's text in differential, the text was not properly
rendered. Now the quoted text is rendered nicely and it's easy to locate.

Test Plan:
Disabled the inline cache, Checked that quotes in D211086 are rendered
correctly. Started writing a new comment starting with '>' and made
sure the new comment was rendered correctly while writing it.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, tuomaspelkonen, epriestley
Differential Revision: 138
This commit is contained in:
tuomaspelkonen 2011-04-14 12:52:28 -07:00
parent b029cb8b4a
commit 28155a5115
3 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/parser/markup/DifferentialMarkupEngineFactory.php
View file

@ -38,6 +38,7 @@ class DifferentialMarkupEngineFactory {
$rules[] = new PhutilRemarkupRuleItalic(); $rules[] = new PhutilRemarkupRuleItalic();
$blocks = array(); $blocks = array();
$blocks[] = new PhutilRemarkupEngineRemarkupQuotesBlockRule();
$blocks[] = new PhutilRemarkupEngineRemarkupHeaderBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupHeaderBlockRule();
$blocks[] = new PhutilRemarkupEngineRemarkupListBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupListBlockRule();
$blocks[] = new PhutilRemarkupEngineRemarkupCodeBlockRule(); $blocks[] = new PhutilRemarkupEngineRemarkupCodeBlockRule();

1
src/applications/differential/parser/markup/__init__.php
View file

@ -16,6 +16,7 @@ phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupcode')
phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupdefault'); phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupdefault');
phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupheader'); phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupheader');
phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkuplist'); phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkuplist');
phutil_require_module('phutil', 'markup/engine/remarkup/blockrule/remarkupquotes');
phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/bold'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/bold');
phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escapehtml'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escapehtml');
phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escaperemarkup'); phutil_require_module('phutil', 'markup/engine/remarkup/markuprule/escaperemarkup');

8
webroot/rsrc/css/core/remarkup.css
View file

@ -40,3 +40,11 @@
.phabricator-remarkup h2 { .phabricator-remarkup h2 {
margin: .75em 0 .5em; margin: .75em 0 .5em;
} }
.phabricator-remarkup blockquote {
border-left: 1px solid #AAAAAA;
color: #333333;
font-style: italic;
margin: .5em 0em;
padding: .25em 1em;
}