revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 01:18:22 +01:00
Code Issues Releases Wiki Activity

Rename "BuildStepImplementation" to "HarbormasterBuildStepImplementation"

Browse source 
Summary: Ref T1049. D8588 already required custom code to change what it extends, so this is as good a time as we're going to get to move to more standard class name.

Test Plan: `arc liberate`; `arc lint`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D8601
This commit is contained in:
epriestley 2014-03-25 16:09:21 -07:00
parent a246c85c6b
commit 281f06e281
14 changed files with 31 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/__phutil_library_map__.php
View file

@ -92,7 +92,6 @@ phutil_register_library_map(array(
'AphrontView' => 'view/AphrontView.php',
'AphrontWebpageResponse' => 'aphront/response/AphrontWebpageResponse.php',
'AuditActionMenuEventListener' => 'applications/audit/events/AuditActionMenuEventListener.php',
'BuildStepImplementation' => 'applications/harbormaster/step/BuildStepImplementation.php',
'CalendarColors' => 'applications/calendar/constants/CalendarColors.php',
'CalendarConstants' => 'applications/calendar/constants/CalendarConstants.php',
'CalendarTimeUtil' => 'applications/calendar/util/CalendarTimeUtil.php',
@ -715,6 +714,7 @@ phutil_register_library_map(array(
'HarbormasterBuildStepCoreCustomField' => 'applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php',
'HarbormasterBuildStepCustomField' => 'applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php',
'HarbormasterBuildStepEditor' => 'applications/harbormaster/editor/HarbormasterBuildStepEditor.php',
'HarbormasterBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterBuildStepImplementation.php',
'HarbormasterBuildStepQuery' => 'applications/harbormaster/query/HarbormasterBuildStepQuery.php',
'HarbormasterBuildStepTransaction' => 'applications/harbormaster/storage/configuration/HarbormasterBuildStepTransaction.php',
'HarbormasterBuildStepTransactionQuery' => 'applications/harbormaster/query/HarbormasterBuildStepTransactionQuery.php',
@ -2663,7 +2663,7 @@ phutil_register_library_map(array(
'CelerityResourceGraph' => 'AbstractDirectedGraph',
'CelerityResourceTransformerTestCase' => 'PhabricatorTestCase',
'CelerityResourcesOnDisk' => 'CelerityPhysicalResources',
'CommandBuildStepImplementation' => 'BuildStepImplementation',
'CommandBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'ConduitAPIMethod' =>
array(
0 => 'Phobject',
@ -3353,7 +3353,7 @@ phutil_register_library_map(array(
'HarbormasterCapabilityManagePlans' => 'PhabricatorPolicyCapability',
'HarbormasterController' => 'PhabricatorController',
'HarbormasterDAO' => 'PhabricatorLiskDAO',
'HarbormasterHTTPRequestBuildStepImplementation' => 'BuildStepImplementation',
'HarbormasterHTTPRequestBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'HarbormasterManagementBuildWorkflow' => 'HarbormasterManagementWorkflow',
'HarbormasterManagementWorkflow' => 'PhabricatorManagementWorkflow',
'HarbormasterObject' => 'HarbormasterDAO',
@ -3381,7 +3381,7 @@ phutil_register_library_map(array(
'HarbormasterStepDeleteController' => 'HarbormasterController',
'HarbormasterStepEditController' => 'HarbormasterController',
'HarbormasterTargetWorker' => 'HarbormasterWorker',
'HarbormasterThrowExceptionBuildStep' => 'BuildStepImplementation',
'HarbormasterThrowExceptionBuildStep' => 'HarbormasterBuildStepImplementation',
'HarbormasterUIEventListener' => 'PhabricatorEventListener',
'HarbormasterWorker' => 'PhabricatorWorker',
'HeraldAction' => 'HeraldDAO',
@ -3448,7 +3448,7 @@ phutil_register_library_map(array(
'JavelinUIExample' => 'PhabricatorUIExample',
'JavelinViewExample' => 'PhabricatorUIExample',
'JavelinViewExampleServerView' => 'AphrontView',
'LeaseHostBuildStepImplementation' => 'BuildStepImplementation',
'LeaseHostBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'LegalpadCapabilityDefaultEdit' => 'PhabricatorPolicyCapability',
'LegalpadCapabilityDefaultView' => 'PhabricatorPolicyCapability',
'LegalpadController' => 'PhabricatorController',
@ -5398,7 +5398,7 @@ phutil_register_library_map(array(
'PonderVoteSaveController' => 'PonderController',
'ProjectCapabilityCreateProjects' => 'PhabricatorPolicyCapability',
'ProjectRemarkupRule' => 'PhabricatorRemarkupRuleObject',
'PublishFragmentBuildStepImplementation' => 'BuildStepImplementation',
'PublishFragmentBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'QueryFormattingTestCase' => 'PhabricatorTestCase',
'ReleephAuthorFieldSpecification' => 'ReleephFieldSpecification',
'ReleephBranch' =>
@ -5502,10 +5502,10 @@ phutil_register_library_map(array(
'ReleephSummaryFieldSpecification' => 'ReleephFieldSpecification',
'ReleephUserView' => 'AphrontView',
'ShellLogView' => 'AphrontView',
'SleepBuildStepImplementation' => 'BuildStepImplementation',
'SleepBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'SlowvoteEmbedView' => 'AphrontView',
'SlowvoteRemarkupRule' => 'PhabricatorRemarkupRuleObject',
'UploadArtifactBuildStepImplementation' => 'BuildStepImplementation',
'WaitForPreviousBuildStepImplementation' => 'BuildStepImplementation',
'UploadArtifactBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
'WaitForPreviousBuildStepImplementation' => 'HarbormasterBuildStepImplementation',
),
));

9
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
View file

@ -164,10 +164,11 @@ final class HarbormasterPlanViewController
$has_conflicts = false;
if ($inputs || $outputs) {
$available_artifacts = BuildStepImplementation::loadAvailableArtifacts(
$plan,
$step,
null);
$available_artifacts =
HarbormasterBuildStepImplementation::loadAvailableArtifacts(
$plan,
$step,
null);
list($inputs_ui, $has_conflicts) = $this->buildArtifactList(
$inputs,

3
src/applications/harbormaster/controller/HarbormasterStepAddController.php
View file

@ -26,7 +26,8 @@ final class HarbormasterStepAddController
throw new Exception("Build plan not found!");
}
$implementations = BuildStepImplementation::getImplementations();
$implementations =
HarbormasterBuildStepImplementation::getImplementations();
$cancel_uri = $this->getApplicationURI('plan/'.$plan->getID().'/');

2
src/applications/harbormaster/step/CommandBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class CommandBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Run Command');

4
src/applications/harbormaster/step/BuildStepImplementation.php → src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
View file

@ -1,10 +1,10 @@
<?php
abstract class BuildStepImplementation {
abstract class HarbormasterBuildStepImplementation {
public static function getImplementations() {
$symbols = id(new PhutilSymbolLoader())
->setAncestorClass('BuildStepImplementation')
->setAncestorClass('HarbormasterBuildStepImplementation')
->setConcreteOnly(true)
->selectAndLoadSymbols();
return ipull($symbols, 'name');

2
src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class HarbormasterHTTPRequestBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Make HTTP Request');

2
src/applications/harbormaster/step/HarbormasterThrowExceptionBuildStep.php
View file

@ -1,7 +1,7 @@
<?php
final class HarbormasterThrowExceptionBuildStep
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Throw Exception');

2
src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class LeaseHostBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Lease Host');

2
src/applications/harbormaster/step/PublishFragmentBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class PublishFragmentBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Publish Fragment');

3
src/applications/harbormaster/step/SleepBuildStepImplementation.php
View file

@ -1,6 +1,7 @@
<?php
final class SleepBuildStepImplementation extends BuildStepImplementation {
final class SleepBuildStepImplementation
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Sleep');

2
src/applications/harbormaster/step/UploadArtifactBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class UploadArtifactBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Upload Artifact');

2
src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php
View file

@ -1,7 +1,7 @@
<?php
final class WaitForPreviousBuildStepImplementation
extends BuildStepImplementation {
extends HarbormasterBuildStepImplementation {
public function getName() {
return pht('Wait for Previous Commits to Build');

3
src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php
View file

@ -88,7 +88,8 @@ final class HarbormasterBuildTarget extends HarbormasterDAO
static $implementations = null;
if ($implementations === null) {
$implementations = BuildStepImplementation::getImplementations();
$implementations =
HarbormasterBuildStepImplementation::getImplementations();
}
$class = $this->className;

3
src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
View file

@ -52,7 +52,8 @@ final class HarbormasterBuildStep extends HarbormasterDAO
static $implementations = null;
if ($implementations === null) {
$implementations = BuildStepImplementation::getImplementations();
$implementations =
HarbormasterBuildStepImplementation::getImplementations();
}
$class = $this->className;