Remove PhabricatorPHID::fromObjectName

Summary: Ref T2715. This only ever supported like 10% of object types; get rid of it in favor of the new infra.

Test Plan:
  - Ran `bin/search index D12`; `bin/search index <some valid phid>`, `bin/search index derp`.
  - Turned off Search jump, searched for `D12`.
  - Used `phid.lookup`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6519

src/applications/phid/conduit/ConduitAPI_phid_lookup_Method.php

@@ -26,34 +26,22 @@ final class ConduitAPI_phid_lookup_Method
 
   protected function execute(ConduitAPIRequest $request) {
     $names = $request->getValue('names');
-    $phids = array();
-    foreach ($names as $name) {
-      $phid = PhabricatorPHID::fromObjectName($name, $request->getUser());
-      if ($phid) {
-        $phids[$name] = $phid;
-      }
-    }
 
     $query = id(new PhabricatorObjectQuery())
       ->setViewer($request->getUser())
       ->withNames($names);
     $query->execute();
-    $objects = $query->getNamedResults();
+    $name_map = $query->getNamedResults();
 
-    foreach ($objects as $name => $object) {
+    $handles = id(new PhabricatorObjectHandleData(mpull($name_map, 'getPHID')))
-      $phids[$name] = $object->getPHID();
-    }
-
-    $handles = id(new PhabricatorObjectHandleData($phids))
       ->setViewer($request->getUser())
       ->loadHandles();
 
     $result = array();
-    foreach ($phids as $name => $phid) {
+    foreach ($name_map as $name => $object) {
-      if (isset($handles[$phid]) && $handles[$phid]->isComplete()) {
+      $phid = $object->getPHID();
-        $result[$name] = $this->buildHandleInformationDictionary(
+      $handle = $handles[$phid];
-          $handles[$phid]);
+      $result[$phid] = $this->buildHandleInformationDictionary($handle);
-      }
     }
 
     return $result;

src/applications/phid/query/PhabricatorObjectQuery.php

@@ -19,12 +19,50 @@ final class PhabricatorObjectQuery
   }
 
   public function loadPage() {
+    if ($this->namedResults === null) {
+      $this->namedResults = array();
+    }
+
     $types = PhabricatorPHIDType::getAllTypes();
 
-    $this->namedResults = $this->loadObjectsByName($types);
+    $names = $this->names;
+    $phids = $this->phids;
 
-    return $this->loadObjectsByPHID($types) +
+    // We allow objects to be named by their PHID in addition to their normal
-           mpull($this->namedResults, null, 'getPHID');
+    // name so that, e.g., CLI tools which accept object names can also accept
+    // PHIDs and work as users expect.
+    $actually_phids = array();
+    if ($names) {
+      foreach ($names as $key => $name) {
+        if (!strncmp($name, 'PHID-', 5)) {
+          $actually_phids[] = $name;
+          $phids[] = $name;
+          unset($names[$key]);
+        }
+      }
+    }
+
+    if ($names) {
+      $name_results = $this->loadObjectsByName($types, $names);
+    } else {
+      $name_results = array();
+    }
+
+    if ($phids) {
+      $phid_results = $this->loadObjectsByPHID($types, $phids);
+    } else {
+      $phid_results = array();
+    }
+
+    foreach ($actually_phids as $phid) {
+      if (isset($phid_results[$phid])) {
+        $name_results[$phid] = $phid_results[$phid];
+      }
+    }
+
+    $this->namedResults += $name_results;
+
+    return $phid_results + mpull($name_results, null, 'getPHID');
   }
 
   public function getNamedResults() {
@@ -34,12 +72,7 @@ final class PhabricatorObjectQuery
     return $this->namedResults;
   }
 
-  private function loadObjectsByName(array $types) {
+  private function loadObjectsByName(array $types, array $names) {
-    $names = $this->names;
-    if (!$names) {
-      return array();
-    }
-
     $groups = array();
     foreach ($names as $name) {
       foreach ($types as $type => $type_impl) {
@@ -59,12 +92,7 @@ final class PhabricatorObjectQuery
     return $results;
   }
 
-  private function loadObjectsByPHID(array $types) {
+  private function loadObjectsByPHID(array $types, array $phids) {
-    $phids = $this->phids;
-    if (!$phids) {
-      return array();
-    }
-
     $groups = array();
     foreach ($phids as $phid) {
       $type = phid_get_type($phid);

src/applications/phid/storage/PhabricatorPHID.php

@@ -24,30 +24,4 @@ final class PhabricatorPHID {
     return "PHID-{$type_str}-{$uniq}";
   }
 
-  public static function fromObjectName($name, PhabricatorUser $viewer) {
-    $query = id(new PhabricatorObjectQuery())
-      ->setViewer($viewer)
-      ->withNames(array($name));
-    $query->execute();
-
-    $objects = $query->getNamedResults();
-    if ($objects) {
-      return head($objects)->getPHID();
-    }
-
-    /// TODO: Destroy this legacy stuff.
-
-    $object = null;
-    $match = null;
-    if (preg_match('/^PHID-[A-Z]+-.{20}$/', $name)) {
-      // It's already a PHID! Yay.
-      return $name;
-    }
-
-    if ($object) {
-      return $object->getPHID();
-    }
-
-    return null;
-  }
 }

src/applications/search/controller/PhabricatorSearchController.php

@@ -220,10 +220,16 @@ final class PhabricatorSearchController
       $results = $engine->executeSearch($query);
       $results = $pager->sliceResults($results);
 
+      // If there are any objects which match the query by name, and we're
+      // not paging through the results, prefix the results with the named
+      // objects.
       if (!$request->getInt('page')) {
-        $jump = PhabricatorPHID::fromObjectName($query->getQuery(), $user);
+        $named = id(new PhabricatorObjectQuery())
-        if ($jump) {
+          ->setViewer($user)
-          array_unshift($results, $jump);
+          ->withNames(array($query->getQuery()))
+          ->execute();
+        if ($named) {
+          $results = array_merge(array_keys($named), $results);
         }
       }
 

src/applications/search/management/PhabricatorSearchManagementIndexWorkflow.php

@@ -91,18 +91,20 @@ final class PhabricatorSearchManagementIndexWorkflow
   }
 
   private function loadPHIDsByNames(array $names) {
-    $phids = array();
+    $query = id(new PhabricatorObjectQuery())
+      ->setViewer(PhabricatorUser::getOmnipotentUser())
+      ->withNames($names);
+    $query->execute();
+    $objects = $query->getNamedResults();
+
     foreach ($names as $name) {
-      $phid = PhabricatorPHID::fromObjectName(
+      if (empty($objects[$name])) {
-        $name,
-        PhabricatorUser::getOmnipotentUser());
-      if (!$phid) {
         throw new PhutilArgumentUsageException(
           "'{$name}' is not the name of a known object.");
       }
-      $phids[] = $phid;
     }
-    return $phids;
+
+    return mpull($objects, 'getPHID');
   }
 
   private function loadPHIDsByTypes($type) {