1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00

Minor fixes to maniphest feed/notification

Summary:
Added `renderNotificationView()` abstract function to `PhabricatorFeedStory` base class.
Fixed duplicate line in `PhabricatorFeedStoryManiphest` class.
Fixed spacing/formatting in `ManiphestTransactionEditor`.

Test Plan: No functional changes

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: allenjohnashton, ddfisher, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2698
This commit is contained in:
Keebuhm Park 2012-06-08 19:11:32 -07:00 committed by epriestley
parent c67f45734d
commit 284d7b6a46
3 changed files with 2 additions and 4 deletions

View file

@ -28,6 +28,7 @@ abstract class PhabricatorFeedStory {
} }
abstract public function renderView(); abstract public function renderView();
abstract public function renderNotificationView();
public function getRequiredHandlePHIDs() { public function getRequiredHandlePHIDs() {
return array(); return array();

View file

@ -70,7 +70,6 @@ final class PhabricatorFeedStoryManiphest
$view = new PhabricatorNotificationStoryView(); $view = new PhabricatorNotificationStoryView();
$view->setEpoch($data->getEpoch());
$view->setTitle($this->getLineForData($data)); $view->setTitle($this->getLineForData($data));
$view->setEpoch($data->getEpoch()); $view->setEpoch($data->getEpoch());
$view->setViewed($this->getHasViewed()); $view->setViewed($this->getHasViewed());

View file

@ -369,9 +369,7 @@ final class ManiphestTransactionEditor {
array( array(
$author_phid, $author_phid,
$owner_phid, $owner_phid,
$actor_phid $actor_phid)),
)
),
$task->getCCPHIDs())) $task->getCCPHIDs()))
->publish(); ->publish();
} }