From 28a5f9f44d1a63920a358d7252cbfaf90c28aa9b Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 23 Jan 2012 22:36:03 -0800 Subject: [PATCH] Display comment title as title instead of body with inline comments Test Plan: Display revision containing comments with no content but with inline comments. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1474 --- .../view/revisioncomment/DifferentialRevisionCommentView.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php index d66950a51d..c472e3ba35 100644 --- a/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php +++ b/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php @@ -137,7 +137,6 @@ final class DifferentialRevisionCommentView extends AphrontView { $content = $comment->getContent(); $head_content = null; if (strlen(rtrim($content))) { - $title = "{$author_link} {$verb} this revision:"; $cache = $comment->getCache(); if (strlen($cache)) { $content = $cache; @@ -155,6 +154,9 @@ final class DifferentialRevisionCommentView extends AphrontView { '
'. $content. '
'; + } + if (strlen(rtrim($content)) || $this->inlines) { + $title = "{$author_link} {$verb} this revision:"; } else { $title = null; $head_content =