From 28b606394be427ae27e0467c4c10f91fff2d6348 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 4 Jan 2012 07:18:16 -0800
Subject: [PATCH] Fix undefined variable warning in unit test field

Summary:
See D1295. $unit_messages may be undefined.

I'll see if I can improve the visibility of warnings, the red dot in DarkConsole
is easy to miss right now. See T734.

Test Plan: Loaded a revision with no unit failures, didn't receive a warning.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Differential Revision: https://secure.phabricator.com/D1306
---
 .../unit/DifferentialUnitFieldSpecification.php  | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php b/src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
index 9f38133eae..8e3fda1e77 100644
--- a/src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
+++ b/src/applications/differential/field/specification/unit/DifferentialUnitFieldSpecification.php
@@ -67,14 +67,14 @@ final class DifferentialUnitFieldSpecification
           $postponed_count++;
         }
       }
-    }
-    if ($unit_messages) {
-      $utail =
-        '<div class="differential-unit-block">'.
-          '<ul>'.
-            implode("\n", $unit_messages).
-          '</ul>'.
-        '</div>';
+      if ($unit_messages) {
+        $utail =
+          '<div class="differential-unit-block">'.
+            '<ul>'.
+              implode("\n", $unit_messages).
+            '</ul>'.
+          '</div>';
+      }
     }
 
     if ($postponed_count > 0 &&