From 28dfeeb5d5036a9b33646c24db3341986481a7c5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 10 Apr 2012 15:39:59 -0700 Subject: [PATCH] Make sure exceptions are surfaced from setup Summary: If setup throws an exception, we may swallow it currently. Make sure it's printed. Test Plan: Changed "git" to "qit" to force a command failure, ran setup, got a more useful error. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2197 --- webroot/index.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/webroot/index.php b/webroot/index.php index 7c8153e7b8..993a499ad3 100644 --- a/webroot/index.php +++ b/webroot/index.php @@ -97,7 +97,12 @@ foreach (PhabricatorEnv::getEnvConfig('load-libraries') as $library) { } if (PhabricatorEnv::getEnvConfig('phabricator.setup')) { - PhabricatorSetup::runSetup(); + try { + PhabricatorSetup::runSetup(); + } catch (Exception $ex) { + echo "EXCEPTION!\n"; + echo $ex; + } return; }