mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Fix margins and spacing of other revision lists
Summary: Fixes spacing in Differential revision detail and Diffusion browse views. Test Plan: {F48677} {F48678} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D6359
This commit is contained in:
parent
457503838f
commit
29658db32e
3 changed files with 17 additions and 15 deletions
|
@ -840,12 +840,11 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
|||
$handles = $this->loadViewerHandles($phids);
|
||||
$view->setHandles($handles);
|
||||
|
||||
return hsprintf(
|
||||
'%s<div class="differential-panel">%s</div>',
|
||||
return array(
|
||||
id(new PhabricatorHeaderView())
|
||||
->setHeader(pht('Open Revisions Affecting These Files'))
|
||||
->render(),
|
||||
$view->render());
|
||||
->setHeader(pht('Open Revisions Affecting These Files')),
|
||||
$view,
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
|
@ -93,13 +93,15 @@ final class DiffusionBrowseController extends DiffusionController {
|
|||
$box->setShadow(true);
|
||||
$box->appendChild($readme);
|
||||
$box->addPadding(PHUI::PADDING_LARGE);
|
||||
$box->addMargin(PHUI::MARGIN_LARGE);
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setHeader(pht('README'));
|
||||
$panel->setNoBackground();
|
||||
$panel->appendChild($box);
|
||||
$header = id(new PhabricatorHeaderView())
|
||||
->setHeader(pht('README'));
|
||||
|
||||
$content[] = $panel;
|
||||
$content[] = array(
|
||||
$header,
|
||||
$box,
|
||||
);
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
@ -133,12 +133,13 @@ abstract class DiffusionController extends PhabricatorController {
|
|||
$handles = $this->loadViewerHandles($phids);
|
||||
$view->setHandles($handles);
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setId('pending-differential-revisions');
|
||||
$panel->setHeader('Pending Differential Revisions');
|
||||
$panel->appendChild($view);
|
||||
$header = id(new PhabricatorHeaderView())
|
||||
->setHeader(pht('Pending Differential Revisions'));
|
||||
|
||||
return $panel;
|
||||
return array(
|
||||
$header,
|
||||
$view,
|
||||
);
|
||||
}
|
||||
|
||||
private function buildCrumbList(array $spec = array()) {
|
||||
|
|
Loading…
Reference in a new issue