1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-24 13:38:19 +01:00

Fix margins and spacing of other revision lists

Summary: Fixes spacing in Differential revision detail and Diffusion browse views.

Test Plan:
{F48677}
{F48678}

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D6359
This commit is contained in:
epriestley 2013-07-03 10:10:07 -07:00
parent 457503838f
commit 29658db32e
3 changed files with 17 additions and 15 deletions

View file

@ -840,12 +840,11 @@ final class DifferentialRevisionViewController extends DifferentialController {
$handles = $this->loadViewerHandles($phids); $handles = $this->loadViewerHandles($phids);
$view->setHandles($handles); $view->setHandles($handles);
return hsprintf( return array(
'%s<div class="differential-panel">%s</div>',
id(new PhabricatorHeaderView()) id(new PhabricatorHeaderView())
->setHeader(pht('Open Revisions Affecting These Files')) ->setHeader(pht('Open Revisions Affecting These Files')),
->render(), $view,
$view->render()); );
} }
/** /**

View file

@ -93,13 +93,15 @@ final class DiffusionBrowseController extends DiffusionController {
$box->setShadow(true); $box->setShadow(true);
$box->appendChild($readme); $box->appendChild($readme);
$box->addPadding(PHUI::PADDING_LARGE); $box->addPadding(PHUI::PADDING_LARGE);
$box->addMargin(PHUI::MARGIN_LARGE);
$panel = new AphrontPanelView(); $header = id(new PhabricatorHeaderView())
$panel->setHeader(pht('README')); ->setHeader(pht('README'));
$panel->setNoBackground();
$panel->appendChild($box);
$content[] = $panel; $content[] = array(
$header,
$box,
);
} }
} }

View file

@ -133,12 +133,13 @@ abstract class DiffusionController extends PhabricatorController {
$handles = $this->loadViewerHandles($phids); $handles = $this->loadViewerHandles($phids);
$view->setHandles($handles); $view->setHandles($handles);
$panel = new AphrontPanelView(); $header = id(new PhabricatorHeaderView())
$panel->setId('pending-differential-revisions'); ->setHeader(pht('Pending Differential Revisions'));
$panel->setHeader('Pending Differential Revisions');
$panel->appendChild($view);
return $panel; return array(
$header,
$view,
);
} }
private function buildCrumbList(array $spec = array()) { private function buildCrumbList(array $spec = array()) {