From 296818e129db8866fc359dae8594ea365e6e522c Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 14 Aug 2013 09:00:25 -0700 Subject: [PATCH] Remove ReleephProject->repositoryID writes Summary: Ref T3655. Depends on D6633. This removes the writes and the column. Test Plan: Created a project, edited a project. Verified the table doesn't have any keys including this column. Reviewers: btrahan Reviewed By: btrahan CC: LegNeato, aran Maniphest Tasks: T3655 Differential Revision: https://secure.phabricator.com/D6634 --- resources/sql/patches/20130731.releephrepoid.sql | 2 ++ .../controller/project/ReleephProjectCreateController.php | 1 - src/applications/releeph/storage/ReleephProject.php | 1 - .../storage/patch/PhabricatorBuiltinPatchList.php | 4 ++++ 4 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 resources/sql/patches/20130731.releephrepoid.sql diff --git a/resources/sql/patches/20130731.releephrepoid.sql b/resources/sql/patches/20130731.releephrepoid.sql new file mode 100644 index 0000000000..d4220892ec --- /dev/null +++ b/resources/sql/patches/20130731.releephrepoid.sql @@ -0,0 +1,2 @@ +ALTER TABLE {$NAMESPACE}_releeph.releeph_project + DROP repositoryID; diff --git a/src/applications/releeph/controller/project/ReleephProjectCreateController.php b/src/applications/releeph/controller/project/ReleephProjectCreateController.php index d478aebe6c..cc423dda65 100644 --- a/src/applications/releeph/controller/project/ReleephProjectCreateController.php +++ b/src/applications/releeph/controller/project/ReleephProjectCreateController.php @@ -34,7 +34,6 @@ final class ReleephProjectCreateController extends ReleephProjectController { $releeph_project = id(new ReleephProject()) ->setName($name) ->setTrunkBranch($trunk_branch) - ->setRepositoryID($pr_repository->getID()) ->setRepositoryPHID($pr_repository->getPHID()) ->setArcanistProjectID($arc_project->getID()) ->setCreatedByUserPHID($request->getUser()->getPHID()) diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php index 7d9c238e89..e961f9cd88 100644 --- a/src/applications/releeph/storage/ReleephProject.php +++ b/src/applications/releeph/storage/ReleephProject.php @@ -18,7 +18,6 @@ final class ReleephProject extends ReleephDAO // been picked and which haven't. protected $trunkBranch; - protected $repositoryID; protected $repositoryPHID; protected $isActive; protected $createdByUserPHID; diff --git a/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php b/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php index 6fa1500047..6c3441cbe6 100644 --- a/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php +++ b/src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php @@ -1535,6 +1535,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList { 'type' => 'sql', 'name' => $this->getPatchPath('20130802.heraldxactions.sql'), ), + '20130731.releephrepoid.sql' => array( + 'type' => 'sql', + 'name' => $this->getPatchPath('20130731.releephrepoid.sql'), + ), ); } }