From 298a30e647a8cb8ab7ab39985bf639159efc81d7 Mon Sep 17 00:00:00 2001
From: James Rhodes <jrhodes@redpointsoftware.com.au>
Date: Fri, 1 Aug 2014 08:08:53 +1000
Subject: [PATCH] Hide build target messages if there are no messages for the
 target

Summary: Ref T1049. This hides the build target messages area if there are no messages for the target.  Since most of the time a build target won't recieve any messages, this area is confusing because it's always empty.

Test Plan: Viewed a build, saw the empty build target message areas disappear.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D10092
---
 .../controller/HarbormasterBuildViewController.php            | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
index 58419976d8..6be70a133c 100644
--- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
@@ -97,7 +97,9 @@ final class HarbormasterBuildViewController
         ->addPropertyList($properties);
 
       $build_messages = idx($messages, $build_target->getPHID(), array());
-      $targets[] = $this->buildMessages($build_messages);
+      if ($build_messages) {
+        $targets[] = $this->buildMessages($build_messages);
+      }
 
       $targets[] = $this->buildArtifacts($build_target);
       $targets[] = $this->buildLog($build, $build_target);