From 29b29c109d3534920a9d9b8a628a12d60c2bc4d2 Mon Sep 17 00:00:00 2001
From: Korvin Szanto <korvinszanto@gmail.com>
Date: Sat, 1 Feb 2014 17:18:44 -0800
Subject: [PATCH] Fix the `What's New?` phabricatorbot handler.

Summary: `What's new` has been broken for awhile, I've updated it to use the `feed.query` text view.

Test Plan: Start up a bot and say "What's new?"

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: fas, epriestley, aran, Kage, demo

Differential Revision: https://secure.phabricator.com/D8118
---
 .../handler/PhabricatorBotWhatsNewHandler.php | 123 ++----------------
 1 file changed, 12 insertions(+), 111 deletions(-)

diff --git a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
index 62a9f2f9b2..e052230410 100644
--- a/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
+++ b/src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php
@@ -1,7 +1,7 @@
 <?php
 
 /**
- * Responds to "Whats new?" using the feed.
+ * Responds to "Whats new?" with some recent feed content
  *
  * @group irc
  */
@@ -10,135 +10,36 @@ final class PhabricatorBotWhatsNewHandler extends PhabricatorBotHandler {
   private $floodblock = 0;
 
   public function receiveMessage(PhabricatorBotMessage $message) {
-
     switch ($message->getCommand()) {
       case 'MESSAGE':
         $message_body = $message->getBody();
+        $now = time();
 
         $prompt = '~what( i|\')?s new\?~i';
         if (preg_match($prompt, $message_body)) {
-          if (time() < $this->floodblock) {
+          if ($now < $this->floodblock) {
             return;
           }
-          $this->floodblock = time() + 60;
-
-          $this->getLatest($message);
+          $this->floodblock = $now + 60;
+          $this->reportNew($message);
         }
         break;
     }
   }
 
-  public function getLatest(PhabricatorBotMessage $message) {
+  public function reportNew(PhabricatorBotMessage $message) {
     $latest = $this->getConduit()->callMethodSynchronous(
       'feed.query',
       array(
-        'limit' => 5
+        'limit' => 5,
+        'view'  => 'text'
       ));
 
-    $phids = array();
-    foreach ($latest as $action) {
-      if (isset($action['data']['actor_phid'])) {
-        $uid = $action['data']['actor_phid'];
-      } else {
-        $uid = $action['authorPHID'];
+    foreach ($latest as $feed_item) {
+      if (isset($feed_item['text'])) {
+        $this->replyTo($message, html_entity_decode($feed_item['text']));
       }
-
-      switch ($action['class']) {
-        case 'PhabricatorFeedStoryDifferential':
-          $phids[] = $action['data']['revision_phid'];
-          break;
-        case 'PhabricatorFeedStoryAudit':
-          $phids[] = $action['data']['commitPHID'];
-          break;
-
-        case 'PhabricatorFeedStoryManiphest':
-          $phids[] = $action['data']['taskPHID'];
-          break;
-
-        default:
-          $phids[] = $uid;
-          break;
-      }
-      array_push($phids, $uid);
-    }
-
-    $infs = $this->getConduit()->callMethodSynchronous(
-      'phid.query',
-      array(
-        'phids'=>$phids
-      ));
-
-    $cphid = 0;
-    foreach ($latest as $action) {
-      if (isset($action['data']['actor_phid'])) {
-        $uid = $action['data']['actor_phid'];
-      } else {
-        $uid = $action['authorPHID'];
-      }
-      switch ($action['class']) {
-        case 'PhabricatorFeedStoryDifferential':
-          $rinf = $infs[$action['data']['revision_phid']];
-          break;
-
-        case 'PhabricatorFeedStoryAudit':
-          $rinf = $infs[$action['data']['commitPHID']];
-          break;
-
-        case 'PhabricatorFeedStoryManiphest':
-          $rinf = $infs[$action['data']['taskPHID']];
-          break;
-
-        default:
-          $rinf = array('name'=>$action['class']);
-          break;
-      }
-      $uinf = $infs[$uid];
-
-      $action = $this->getRhetoric($action['data']['action']);
-      $user = $uinf['name'];
-      $title = $rinf['fullName'];
-      $uri = $rinf['uri'];
-      $color = chr(3);
-      $blue = $color.'12';
-      $gray = $color.'15';
-      $bold = chr(2);
-      $reset = chr(15);
-      // Disabling irc-specific styling, at least for now
-      // $content = "{$bold}{$user}{$reset} {$gray}{$action} {$blue}{$bold}".
-        // "{$title}{$reset} - {$gray}{$uri}{$reset}";
-      $content = "{$user} {$action} {$title} - {$uri}";
-      $this->replyTo($message, $content);
-    }
-    return;
-  }
-
-  public function getRhetoric($input) {
-    switch ($input) {
-      case 'comment':
-      case 'none':
-        return 'commented on';
-        break;
-      case 'update':
-        return 'updated';
-        break;
-      case 'commit':
-        return 'closed';
-        break;
-      case 'create':
-        return 'created';
-        break;
-      case 'concern':
-        return 'raised concern for';
-        break;
-      case 'abandon':
-        return 'abandonned';
-        break;
-      case 'accept':
-        return 'accepted';
-        break;
-      default:
-        return $input;
-        break;
     }
   }
+
 }