revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Don't treat Quicksand requests as isWorkflow() or isAjax()

Browse source 
Summary:
Fixes T7061. Although it's very simple, I think this is a complete fix.

Quicksand technically is Ajax and uses Workflow as a transport mechanism, but the server should always pretend the user clicked a normal link when rendering.

Test Plan: Links that were autoconverting into dialogs (like "Edit Task") or otherwise making the wrong behavioral choices now work as expected.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7061

Differential Revision: https://secure.phabricator.com/D12194
This commit is contained in:
epriestley 2015-03-28 15:45:52 -07:00
parent 43be66d8b9
commit 29beb174d3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/aphront/AphrontRequest.php
View file

@ -192,11 +192,11 @@ final class AphrontRequest {
}
final public function isAjax() {
return $this->getExists(self::TYPE_AJAX);
return $this->getExists(self::TYPE_AJAX) && !$this->isQuicksand();
}
final public function isWorkflow() {
return $this->getExists(self::TYPE_WORKFLOW);
return $this->getExists(self::TYPE_WORKFLOW) && !$this->isQuicksand();
}
final public function isQuicksand() {