From 29d6e5fd4bae08b4015799bd5a3041b8843900ef Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Tue, 26 Jul 2016 04:47:02 -0700 Subject: [PATCH] Use numeric input control for TOTP factor entry Summary: Finishes fixing T11365. rP28199bcb48 added the new numeric entry control and used it for TOTP setup, but missed the case of entering a factor when TOTP was already set up. Test Plan: Observe behaviour of TOTP setup and subsequent factor entry in iOS browser, make sure they're consistent. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Maniphest Tasks: T11365 Differential Revision: https://secure.phabricator.com/D16325 --- src/applications/auth/factor/PhabricatorTOTPAuthFactor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/auth/factor/PhabricatorTOTPAuthFactor.php b/src/applications/auth/factor/PhabricatorTOTPAuthFactor.php index 2910dc0610..8875b960e2 100644 --- a/src/applications/auth/factor/PhabricatorTOTPAuthFactor.php +++ b/src/applications/auth/factor/PhabricatorTOTPAuthFactor.php @@ -151,7 +151,7 @@ final class PhabricatorTOTPAuthFactor extends PhabricatorAuthFactor { } $form->appendChild( - id(new AphrontFormTextControl()) + id(new PHUIFormNumberControl()) ->setName($this->getParameterName($config, 'totpcode')) ->setLabel(pht('App Code')) ->setCaption(pht('Factor Name: %s', $config->getFactorName()))