revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Don't exit from the Aphlict Server prematurely

Browse source 
Summary: By calling `process.exit(1)` we are forcing the Node.js process to exit prematurely. Specifically, the process is terminated before the error is written to the log file. This can be verified by inspecting the value of `debug._logs[0]._writableState.writing` immediately before the process is terminated.

Test Plan: Ran `./bin/aphlict debug` without the `ws` module being installed. Verified that `<<< UNCAUGHT EXCEPTION! >>>` was echoed to the console as well as the log file. Also verified that the exit status was non-zero.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11426
This commit is contained in:
Joshua Spence 2015-01-20 06:36:51 +11:00
parent 3bc54c2041
commit 2b12f61602
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
support/aphlict/server/aphlict_server.js
View file

@ -60,8 +60,6 @@ process.on('uncaughtException', function(err) {
message.push(err.stack); message.push(err.stack);
debug.log(message.join('\n\n')); debug.log(message.join('\n\n'));
process.exit(1);
}); });
try { try {