revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Don't hang on /status/ for newer Node

Browse source 
Summary: At some point, Node started requiring us to read data before we can get the 'end' event, it seems. Fixes T2953.

Test Plan: Ran server in `--foreground` mode on node v0.11.0, made request to `/status/`, got response.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2953

Differential Revision: https://secure.phabricator.com/D5666
This commit is contained in:
epriestley 2013-04-11 15:45:50 -07:00
parent 7b9b872b29
commit 2b8adb3a83
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
support/aphlict/server/aphlict_server.js
View file

@ -182,6 +182,11 @@ var receive_server = http.createServer(function(request, response) {
response.end(); response.end();
}); });
} else if (request.url == '/status/') { } else if (request.url == '/status/') {
request.on('data', function(data) {
// We just ignore the request data, but newer versions of Node don't
// get to 'end' if we don't process the data. See T2953.
});
request.on('end', function() { request.on('end', function() {
var status = { var status = {
'uptime': (new Date().getTime() - start_time), 'uptime': (new Date().getTime() - start_time),