From 2bade93b76c005d9de89cbc31f261c64976abc69 Mon Sep 17 00:00:00 2001
From: David Fisher <ddf1991@gmail.com>
Date: Mon, 11 Jun 2012 17:16:55 -0700
Subject: [PATCH] Notification dropdown fixes

Summary: dropdown now displays properly and without flicker

Test Plan: tested locally

Reviewers: epriestley

Reviewed By: epriestley

CC: allenjohnashton, keebuhm, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2708
---
 src/__celerity_resource_map__.php                            | 2 +-
 src/view/page/PhabricatorStandardPageView.php                | 5 +++--
 .../rsrc/js/application/aphlict/behavior-aphlict-dropdown.js | 3 ---
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php
index e190e040aa..731e5596c0 100644
--- a/src/__celerity_resource_map__.php
+++ b/src/__celerity_resource_map__.php
@@ -758,7 +758,7 @@ celerity_register_resource_map(array(
   ),
   'javelin-behavior-aphlict-dropdown' =>
   array(
-    'uri' => '/res/d0025c08/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
+    'uri' => '/res/40c65741/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
     'type' => 'js',
     'requires' =>
     array(
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
index 1ece236fe3..f190f5fbf9 100644
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -414,8 +414,9 @@ final class PhabricatorStandardPageView extends AphrontPageView {
           'div',
           array(
             'sigil' => 'aphlict-dropdown',
-            'id'    =>  'phabricator-notification-dropdown',
-                ),
+            'id'    => 'phabricator-notification-dropdown',
+            'style' => 'display: none',
+          ),
           '');
     }
 
diff --git a/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js b/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
index 29e9c185cc..14637ff099 100644
--- a/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
+++ b/webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js
@@ -12,9 +12,6 @@ JX.behavior('aphlict-dropdown', function(config) {
   var indicator = JX.$('phabricator-notification-indicator');
   var visible = false;
 
-
-  JX.DOM.hide(dropdown);
-
   //populate panel
   (new JX.Request('/notification/panel/',
     function(response) {