From 2bccbe454349ef9c1d49c72bf62d5f682e973bd5 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 15 Feb 2015 18:14:41 -0800 Subject: [PATCH] Clean up blank states on Phriction Summary: Removes odd margin. Also removes min-height on content. Test Plan: Test a fresh Phriction, and a deleted page. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D11775 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/phui/phui-document.css | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 3fc879baa8..8c06396d2a 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -126,7 +126,7 @@ return array( 'rsrc/css/phui/phui-box.css' => '7b3a2eed', 'rsrc/css/phui/phui-button.css' => 'ffe12633', 'rsrc/css/phui/phui-crumbs-view.css' => '594d719e', - 'rsrc/css/phui/phui-document.css' => 'a494bdf8', + 'rsrc/css/phui/phui-document.css' => '8240b0b1', 'rsrc/css/phui/phui-error-view.css' => 'ad042fdd', 'rsrc/css/phui/phui-feed-story.css' => 'c9f3a0b5', 'rsrc/css/phui/phui-fontkit.css' => '9ae12677', @@ -779,7 +779,7 @@ return array( 'phui-calendar-list-css' => 'c1d0ca59', 'phui-calendar-month-css' => 'a92e47d2', 'phui-crumbs-view-css' => '594d719e', - 'phui-document-view-css' => 'a494bdf8', + 'phui-document-view-css' => '8240b0b1', 'phui-error-view-css' => 'ad042fdd', 'phui-feed-story-css' => 'c9f3a0b5', 'phui-font-icon-base-css' => '3dad2ae3', diff --git a/webroot/rsrc/css/phui/phui-document.css b/webroot/rsrc/css/phui/phui-document.css index 83295bef09..2f3eab313d 100644 --- a/webroot/rsrc/css/phui/phui-document.css +++ b/webroot/rsrc/css/phui/phui-document.css @@ -102,12 +102,7 @@ } .phui-document-content { - min-height: 240px; background: #fff; - - /* NOTE: This fixes margins, not floats, and can not be replaced with - the ".group" class. See T3150. - */ overflow: hidden; } @@ -152,3 +147,7 @@ .phui-document-view .phui-property-list-view { border-bottom: 1px solid {$thinblueborder}; } + +.phui-document-view .phui-error-severity-nodata { + background-color: {$lightgreybackground}; +}