Introduce PHID generation.

src/__phutil_library_map__.php

@@ -60,6 +60,14 @@ phutil_register_library_map(array(
     'PhabricatorDirectoryItemListController' => 'applications/directory/controller/itemlist',
     'PhabricatorDirectoryMainController' => 'applications/directory/controller/main',
     'PhabricatorLiskDAO' => 'applications/base/storage/lisk',
+    'PhabricatorPHID' => 'applications/phid/storage/phid',
+    'PhabricatorPHIDAllocateController' => 'applications/phid/controller/allocate',
+    'PhabricatorPHIDController' => 'applications/phid/controller/base',
+    'PhabricatorPHIDDAO' => 'applications/phid/storage/base',
+    'PhabricatorPHIDListController' => 'applications/phid/controller/list',
+    'PhabricatorPHIDType' => 'applications/phid/storage/type',
+    'PhabricatorPHIDTypeEditController' => 'applications/phid/controller/typeedit',
+    'PhabricatorPHIDTypeListController' => 'applications/phid/controller/typelist',
     'PhabricatorStandardPageView' => 'view/page/standard',
   ),
   'function' =>
@@ -114,6 +122,14 @@ phutil_register_library_map(array(
     'PhabricatorDirectoryItemListController' => 'PhabricatorDirectoryController',
     'PhabricatorDirectoryMainController' => 'PhabricatorDirectoryController',
     'PhabricatorLiskDAO' => 'LiskDAO',
+    'PhabricatorPHID' => 'PhabricatorPHIDDAO',
+    'PhabricatorPHIDAllocateController' => 'PhabricatorPHIDController',
+    'PhabricatorPHIDController' => 'PhabricatorController',
+    'PhabricatorPHIDDAO' => 'PhabricatorLiskDAO',
+    'PhabricatorPHIDListController' => 'PhabricatorPHIDController',
+    'PhabricatorPHIDType' => 'PhabricatorPHIDDAO',
+    'PhabricatorPHIDTypeEditController' => 'PhabricatorPHIDController',
+    'PhabricatorPHIDTypeListController' => 'PhabricatorPHIDController',
     'PhabricatorStandardPageView' => 'AphrontPageView',
   ),
   'requires_interface' =>

src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php

@@ -35,18 +35,27 @@ class AphrontDefaultApplicationConfiguration
         'delete/(?<id>\d+)/$'   => 'RepositoryDeleteController',
       ),
       '/' => array(
-        '$'                     => 'AphrontDirectoryMainController',
+        '$'                     => 'PhabricatorDirectoryMainController',
       ),
       '/directory/' => array(
-        'item/$'                      => 'AphrontDirectoryItemListController',
+        'item/$'
-        'item/edit/(?:(?<id>\d+)/)?$' => 'AphrontDirectoryItemEditController',
+          => 'PhabricatorDirectoryItemListController',
-        'item/delete/(?<id>\d+)/'     => 'AphrontDirectoryItemDeleteController',
+        'item/edit/(?:(?<id>\d+)/)?$'
+          => 'PhabricatorDirectoryItemEditController',
+        'item/delete/(?<id>\d+)/'
+          => 'PhabricatorDirectoryItemDeleteController',
         'category/$'
-          => 'AphrontDirectoryCategoryListController',
+          => 'PhabricatorDirectoryCategoryListController',
         'category/edit/(?:(?<id>\d+)/)?$'
-          => 'AphrontDirectoryCategoryEditController',
+          => 'PhabricatorDirectoryCategoryEditController',
         'category/delete/(?<id>\d+)/'
-          => 'AphrontDirectoryCategoryDeleteController',
+          => 'PhabricatorDirectoryCategoryDeleteController',
+      ),
+      '/phid/' => array(
+        '$' => 'PhabricatorPHIDListController',
+        'type/$' => 'PhabricatorPHIDTypeListController',
+        'type/edit/(?:(?<id>\d+)/)?$' => 'PhabricatorPHIDTypeEditController',
+        'new/$' => 'PhabricatorPHIDAllocateController',
       ),
       '.*' => 'AphrontDefaultApplicationController',
     );

src/aphront/response/webpage/AphrontWebpageResponse.php

@@ -32,4 +32,10 @@ class AphrontWebpageResponse extends AphrontResponse {
     return $this->content;
   }
 
+  public function getHeaders() {
+    return array(
+      array('Content-Type', 'text/html; charset=UTF-8'),
+    );
+  }
+
 }

src/applications/base/controller/base/__init__.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'aphront/controller');
+phutil_require_module('phabricator', 'aphront/response/webpage');
+phutil_require_module('phabricator', 'view/page/standard');
+
+
+phutil_require_source('PhabricatorController.php');

src/applications/base/storage/lisk/PhabricatorLiskDAO.php

@@ -42,7 +42,12 @@ abstract class PhabricatorLiskDAO extends LiskDAO {
     if (!strncmp($class, $app, strlen($app))) {
       $class = substr($class, strlen($app));
     }
-    return $app.'_'.$class;
+
+    if (strlen($class)) {
+      return $app.'_'.$class;
+    } else {
+      return $app;
+    }
   }
 
   abstract public function getApplicationName();

src/applications/directory/storage/item/PhabricatorDirectoryItem.php

@@ -23,7 +23,7 @@ class PhabricatorDirectoryItem extends PhabricatorDirectoryDAO {
   protected $href;
   protected $categoryID;
   protected $sequence;
-  protected $imageGUID;
+  protected $imagePHID;
 
   public function getSortKey() {
     return sprintf(

src/applications/phid/controller/allocate/PhabricatorPHIDAllocateController.php

@@ -0,0 +1,68 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDAllocateController
+  extends PhabricatorPHIDController {
+
+  public function processRequest() {
+
+    $request = $this->getRequest();
+    if ($request->isFormPost()) {
+      $type = $request->getStr('type');
+      $phid = PhabricatorPHID::generateNewPHID($type);
+
+      return id(new AphrontRedirectResponse())
+        ->setURI('/phid/?phid='.phutil_escape_uri($phid));
+    }
+
+    $types = id(new PhabricatorPHIDType())->loadAll();
+    
+    $options = array();
+    foreach ($types as $type) {
+      $options[$type->getType()] = $type->getType().': '.$type->getName();
+    }
+    asort($options);
+
+    $form = new AphrontFormView();
+    $form->setAction('/phid/new/');
+
+    $form
+      ->appendChild(
+        id(new AphrontFormSelectControl())
+          ->setLabel('PHID Type')
+          ->setName('type')
+          ->setOptions($options))
+      ->appendChild(
+        id(new AphrontFormSubmitControl())
+          ->setValue('Allocate')
+          ->addCancelButton('/phid/'));
+
+    $panel = new AphrontPanelView();
+    $panel->setHeader('Allocate New PHID');
+
+    $panel->appendChild($form);
+    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+
+    return $this->buildStandardPageResponse(
+      array($panel),
+      array(
+        'title' => 'Allocate New PHID',
+      ));
+  }
+
+}

src/applications/phid/controller/allocate/__init__.php

@@ -0,0 +1,20 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'aphront/response/redirect');
+phutil_require_module('phabricator', 'applications/phid/controller/base');
+phutil_require_module('phabricator', 'applications/phid/storage/phid');
+phutil_require_module('phabricator', 'applications/phid/storage/type');
+phutil_require_module('phabricator', 'view/form/base');
+phutil_require_module('phabricator', 'view/form/control/submit');
+phutil_require_module('phabricator', 'view/layout/panel');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHIDAllocateController.php');

src/applications/phid/controller/base/PhabricatorPHIDController.php

@@ -0,0 +1,46 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+abstract class PhabricatorPHIDController extends PhabricatorController {
+
+  public function buildStandardPageResponse($view, array $data) {
+    $page = new PhabricatorStandardPageView();
+
+    $page->setApplicationName('PHID');
+    $page->setBaseURI('/phid/');
+    $page->setTitle(idx($data, 'title'));
+    $page->setTabs(
+      array(
+        'phids' => array(
+          'href' => '/phid/',
+          'name' => 'PHIDs',
+        ),
+        'types' => array(
+          'href' => '/phid/type/',
+          'name' => 'PHID Types',
+        ),
+      ),
+      idx($data, 'tab'));
+    $page->setGlyph('#');
+    $page->appendChild($view);
+
+    $response = new AphrontWebpageResponse();
+    return $response->setContent($page->render());
+  }
+
+}

src/applications/phid/controller/base/__init__.php

@@ -0,0 +1,16 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'aphront/response/webpage');
+phutil_require_module('phabricator', 'applications/base/controller/base');
+phutil_require_module('phabricator', 'view/page/standard');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHIDController.php');

src/applications/phid/controller/list/PhabricatorPHIDListController.php

@@ -0,0 +1,56 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDListController
+  extends PhabricatorPHIDController {
+
+  public function processRequest() {
+    $items = id(new PhabricatorPHID())->loadAllWhere(
+      '1 = 1 ORDER BY id DESC limit 100');
+
+    $rows = array();
+    foreach ($items as $item) {
+      $rows[] = array(
+        phutil_escape_html($item->getPHID()),
+        phutil_escape_html($item->getPHIDType()),
+        phutil_escape_html($item->getOwnerPHID()),
+        phutil_escape_html($item->getParentPHID()),
+      );
+    }
+
+    $table = new AphrontTableView($rows);
+    $table->setHeaders(
+      array(
+        'PHID',
+        'Type',
+        'Owner PHID',
+        'Parent PHID',
+      ));
+
+    $panel = new AphrontPanelView();
+    $panel->appendChild($table);
+    $panel->setHeader('PHIDs');
+    $panel->setCreateButton('Allocate New PHID', '/phid/new/');
+
+    return $this->buildStandardPageResponse($panel, array(
+      'title' => 'PHIDs',
+      'tab'   => 'phids',
+      ));
+  }
+
+}

src/applications/phid/controller/list/__init__.php

@@ -0,0 +1,18 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/phid/controller/base');
+phutil_require_module('phabricator', 'applications/phid/storage/phid');
+phutil_require_module('phabricator', 'view/control/table');
+phutil_require_module('phabricator', 'view/layout/panel');
+
+phutil_require_module('phutil', 'markup');
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHIDListController.php');

src/applications/phid/controller/typeedit/PhabricatorPHIDTypeEditController.php

@@ -0,0 +1,132 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDTypeEditController
+  extends PhabricatorPHIDController {
+
+  private $id;
+
+  public function willProcessRequest(array $data) {
+    $this->id = idx($data, 'id');
+  }
+
+  public function processRequest() {
+
+    if ($this->id) {
+      $type = id(new PhabricatorPHIDType())->load($this->id);
+      if (!$type) {
+        return new Aphront404Response();
+      }
+    } else {
+      $type = new PhabricatorPHIDType();
+    }
+
+    $e_type = true;
+    $e_name = true;
+    $errors = array();
+
+    $request = $this->getRequest();
+    if ($request->isFormPost()) {
+      $type->setName($request->getStr('name'));
+      if (!$type->getID()) {
+        $type->setType($request->getStr('type'));
+      }
+      $type->setDescription($request->getStr('description'));
+
+      if (!strlen($type->getType())) {
+        $errors[] = 'Type code is required.';
+        $e_type = 'Required';
+      }
+
+      if (!strlen($type->getName())) {
+        $errors[] = 'Type name is required.';
+        $e_name = 'Required';
+      }
+
+      if (!$errors) {
+        $type->save();
+        return id(new AphrontRedirectResponse())
+          ->setURI('/phid/type/');
+      }
+    }
+
+    $error_view = null;
+    if ($errors) {
+      $error_view = id(new AphrontErrorView())
+        ->setTitle('Form Errors')
+        ->setErrors($errors);
+    }
+
+    $form = new AphrontFormView();
+    if ($type->getID()) {
+      $form->setAction('/phid/type/edit/'.$type->getID().'/');
+    } else {
+      $form->setAction('/phid/type/edit/');
+    }
+
+    if ($type->getID()) {
+      $type_immutable = true;
+    } else {
+      $type_immutable = false;
+    }
+
+    $form
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setLabel('Type')
+          ->setName('type')
+          ->setValue($type->getType())
+          ->setError($e_type)
+          ->setCaption(
+            'Four character type identifier. This can not be changed once '.
+            'it is created.')
+          ->setDisabled($type_immutable))
+      ->appendChild(
+        id(new AphrontFormTextControl())
+          ->setLabel('Name')
+          ->setName('name')
+          ->setValue($type->getName())
+          ->setError($e_name))
+      ->appendChild(
+        id(new AphrontFormTextAreaControl())
+          ->setLabel('Description')
+          ->setName('description')
+          ->setValue($type->getDescription()))
+      ->appendChild(
+        id(new AphrontFormSubmitControl())
+          ->setValue('Save')
+          ->addCancelButton('/phid/type/'));
+
+    $panel = new AphrontPanelView();
+    if ($type->getID()) {
+      $panel->setHeader('Edit PHID Type');
+    } else {
+      $panel->setHeader('Create New PHID Type');
+    }
+
+    $panel->appendChild($form);
+    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+
+    return $this->buildStandardPageResponse(
+      array($error_view, $panel),
+      array(
+        'title' => 'Edit PHID Type',
+      ));
+  }
+
+}

src/applications/phid/controller/typeedit/__init__.php

@@ -0,0 +1,21 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'aphront/response/404');
+phutil_require_module('phabricator', 'aphront/response/redirect');
+phutil_require_module('phabricator', 'applications/phid/controller/base');
+phutil_require_module('phabricator', 'applications/phid/storage/type');
+phutil_require_module('phabricator', 'view/form/base');
+phutil_require_module('phabricator', 'view/form/control/submit');
+phutil_require_module('phabricator', 'view/form/error');
+phutil_require_module('phabricator', 'view/layout/panel');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHIDTypeEditController.php');

src/applications/phid/controller/typelist/PhabricatorPHIDTypeListController.php

@@ -0,0 +1,59 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDTypeListController
+  extends PhabricatorPHIDController {
+
+  public function processRequest() {
+    $items = id(new PhabricatorPHIDType())->loadAll();
+
+    $rows = array();
+    foreach ($items as $item) {
+      $rows[] = array(
+        $item->getID(),
+        phutil_escape_html($item->getType()),
+        phutil_escape_html($item->getName()),
+      );
+    }
+
+    $table = new AphrontTableView($rows);
+    $table->setHeaders(
+      array(
+        'ID',
+        'Type Code',
+        'Name',
+      ));
+    $table->setColumnClasses(
+      array(
+        null,
+        null,
+        'wide',
+      ));
+
+    $panel = new AphrontPanelView();
+    $panel->appendChild($table);
+    $panel->setHeader('PHID Types');
+    $panel->setCreateButton('New Type', '/phid/type/edit/');
+
+    return $this->buildStandardPageResponse($panel, array(
+      'title' => 'PHID Types',
+      'tab'   => 'types',
+      ));
+  }
+
+}

src/applications/phid/controller/typelist/__init__.php

@@ -0,0 +1,18 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/phid/controller/base');
+phutil_require_module('phabricator', 'applications/phid/storage/type');
+phutil_require_module('phabricator', 'view/control/table');
+phutil_require_module('phabricator', 'view/layout/panel');
+
+phutil_require_module('phutil', 'markup');
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHIDTypeListController.php');

src/applications/phid/storage/base/PhabricatorPHIDDAO.php

@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDDAO extends PhabricatorLiskDAO {
+
+  public function getApplicationName() {
+    return 'phid';
+  }
+
+}

src/applications/phid/storage/base/__init__.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/base/storage/lisk');
+
+
+phutil_require_source('PhabricatorPHIDDAO.php');

src/applications/phid/storage/phid/PhabricatorPHID.php

@@ -0,0 +1,56 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHID extends PhabricatorPHIDDAO {
+
+  protected $phid;
+  protected $phidType;
+  protected $ownerPHID;
+  protected $parentPHID;
+
+  public static function generateNewPHID($type, array $config = array()) {
+    $owner  = idx($config, 'owner');
+    $parent = idx($config, 'parent');
+
+    if (!$type) {
+      throw new Exception("Can not generate PHID with no type.");
+    }
+
+    $urandom = @fopen('/dev/urandom', 'r');
+    if (!$urandom) {
+      throw new Exception("Failed to open /dev/urandom!");
+    }
+    $entropy = fread($urandom, 16);
+    if (strlen($entropy) != 16) {
+      throw new Exception("Failed to read from /dev/urandom!");
+    }
+
+    $uniq = sha1($entropy);
+    $phid = 'PHID-'.$type.'-X-'.$uniq;
+
+    $phid_rec = new PhabricatorPHID();
+    $phid_rec->setPHIDType($type);
+    $phid_rec->setOwnerPHID($owner);
+    $phid_rec->setParentPHID($parent);
+    $phid_rec->setPHID($phid);
+    $phid_rec->save();
+
+    return $phid;
+  }
+
+}

src/applications/phid/storage/phid/__init__.php

@@ -0,0 +1,14 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/phid/storage/base');
+
+phutil_require_module('phutil', 'utils');
+
+
+phutil_require_source('PhabricatorPHID.php');

src/applications/phid/storage/type/PhabricatorPHIDType.php

@@ -0,0 +1,25 @@
+<?php
+
+/*
+ * Copyright 2011 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+class PhabricatorPHIDType extends PhabricatorPHIDDAO {
+
+  protected $type;
+  protected $name;
+  protected $description;
+
+}

src/applications/phid/storage/type/__init__.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * This file is automatically generated. Lint this module to rebuild it.
+ * @generated
+ */
+
+
+
+phutil_require_module('phabricator', 'applications/phid/storage/base');
+
+
+phutil_require_source('PhabricatorPHIDType.php');

src/storage/lisk/dao/LiskDAO.php

@@ -148,7 +148,7 @@ abstract class LiskDAO {
   const CONFIG_OPTIMISTIC_LOCKS     = 'enable-locks';
   const CONFIG_IDS                  = 'id-mechanism';
   const CONFIG_TIMESTAMPS           = 'timestamps';
-  const CONFIG_AUX_GUID             = 'auxiliary-guid';
+  const CONFIG_AUX_PHID             = 'auxiliary-phid';
   const CONFIG_SERIALIZATION        = 'col-serialization';
 
   const SERIALIZATION_NONE          = 'id';
@@ -156,7 +156,7 @@ abstract class LiskDAO {
   const SERIALIZATION_PHP           = 'php';
 
   const IDS_AUTOINCREMENT           = 'ids-auto';
-  const IDS_GUID                    = 'ids-guid';
+  const IDS_PHID                    = 'ids-phid';
   const IDS_MANUAL                  = 'ids-manual';
 
   /**
@@ -208,8 +208,8 @@ abstract class LiskDAO {
    * CONFIG_IDS
    * Lisk objects need to have a unique identifying ID. The three mechanisms
    * available for generating this ID are IDS_AUTOINCREMENT (default, assumes
-   * the ID column is an autoincrement primary key), IDS_GUID (to generate a
+   * the ID column is an autoincrement primary key), IDS_PHID (to generate a
-   * unique GUID for each object) or IDS_MANUAL (you are taking full
+   * unique PHID for each object) or IDS_MANUAL (you are taking full
    * responsibility for ID management).
    *
    * CONFIG_TIMESTAMPS
@@ -218,12 +218,12 @@ abstract class LiskDAO {
    * an object. If you don't want to do this, you may disable this option.
    * By default, this option is ON.
    *
-   * CONFIG_AUX_GUID
+   * CONFIG_AUX_PHID
    * This option can be enabled by being set to some truthy value. The meaning
-   * of this value is defined by your guid generation mechanism. If this option
+   * of this value is defined by your PHID generation mechanism. If this option
-   * is enabled, a `guid' property will be populated with a unique GUID when an
+   * is enabled, a `phid' property will be populated with a unique PHID when an
    * object is created (or if it is saved and does not currently have one). You
-   * need to override generateGUID() and hook it into your GUID generation
+   * need to override generatePHID() and hook it into your PHID generation
    * mechanism for this to work. By default, this option is OFF.
    *
    * CONFIG_SERIALIZATION
@@ -554,9 +554,9 @@ abstract class LiskDAO {
         $properties['datemodified'] = 'dateModified';
       }
 
-      if (!$this->isGUIDPrimaryID() &&
+      if (!$this->isPHIDPrimaryID() &&
-          $this->getConfigOption(self::CONFIG_AUX_GUID)) {
+          $this->getConfigOption(self::CONFIG_AUX_PHID)) {
-        $properties['guid'] = 'guid';
+        $properties['phid'] = 'phid';
       }
     }
     return $properties;
@@ -792,11 +792,11 @@ abstract class LiskDAO {
       case self::IDS_AUTOINCREMENT:
         unset($data[$this->getIDKeyForUse()]);
         break;
-      case self::IDS_GUID:
+      case self::IDS_PHID:
         if (empty($data[$this->getIDKeyForUse()])) {
-          $guid = $this->generateGUID();
+          $phid = $this->generatePHID();
-          $this->setID($guid);
+          $this->setID($phid);
-          $data[$this->getIDKeyForUse()] = $guid;
+          $data[$this->getIDKeyForUse()] = $phid;
         }
         break;
       case self::IDS_MANUAL:
@@ -888,11 +888,11 @@ abstract class LiskDAO {
 
 
   /**
-   * Helper: Whether this class is configured to use GUIDs as the primary ID.
+   * Helper: Whether this class is configured to use PHIDs as the primary ID.
    * @task internal
    */
-  private function isGUIDPrimaryID() {
+  private function isPHIDPrimaryID() {
-    return ($this->getConfigOption(self::CONFIG_IDS) === self::IDS_GUID);
+    return ($this->getConfigOption(self::CONFIG_IDS) === self::IDS_PHID);
   }
 
 
@@ -906,8 +906,8 @@ abstract class LiskDAO {
    */
   public function getIDKey() {
     return
-      $this->isGUIDPrimaryID() ?
+      $this->isPHIDPrimaryID() ?
-      'guid' :
+      'phid' :
       'id';
   }
 
@@ -924,16 +924,16 @@ abstract class LiskDAO {
 
 
   /**
-   * Generate a new GUID, used by CONFIG_AUX_GUID and IDS_GUID.
+   * Generate a new PHID, used by CONFIG_AUX_PHID and IDS_PHID.
    *
-   * @return guid    Unique, newly allocated GUID.
+   * @return phid    Unique, newly allocated PHID.
    *
    * @task   hook
    */
-  protected function generateGUID() {
+  protected function generatePHID() {
     throw new Exception(
-      "To use CONFIG_AUX_GUID or IDS_GUID, you need to overload ".
+      "To use CONFIG_AUX_PHID or IDS_PHID, you need to overload ".
-      "generateGUID() to perform GUID generation.");
+      "generatePHID() to perform PHID generation.");
   }
 
 
@@ -987,14 +987,14 @@ abstract class LiskDAO {
       $this->setDateModified(time());
     }
 
-    if (($this->isGUIDPrimaryID() && !$this->getID())) {
+    if (($this->isPHIDPrimaryID() && !$this->getID())) {
-      // If GUIDs are the primary ID, the subclass could have overridden the
+      // If PHIDs are the primary ID, the subclass could have overridden the
       // name of the ID column.
-      $this->setID($this->generateGUID());
+      $this->setID($this->generatePHID());
-    } else if ($this->getConfigOption(self::CONFIG_AUX_GUID) &&
+    } else if ($this->getConfigOption(self::CONFIG_AUX_PHID) &&
-               !$this->getGUID()) {
+               !$this->getPHID()) {
-      // The subclass could still want GUIDs.
+      // The subclass could still want PHIDs.
-      $this->setGUID($this->generateGUID());
+      $this->setPHID($this->generatePHID());
     }
   }
 

src/view/form/control/base/AphrontFormControl.php

@@ -23,6 +23,7 @@ abstract class AphrontFormControl extends AphrontView {
   private $error;
   private $name;
   private $value;
+  private $disabled;
 
   public function setLabel($label) {
     $this->label = $label;
@@ -69,6 +70,15 @@ abstract class AphrontFormControl extends AphrontView {
     return $this->value;
   }
 
+  public function setDisabled($disabled) {
+    $this->disabled = $disabled;
+    return $this;
+  }
+
+  public function getDisabled() {
+    return $this->disabled;
+  }
+
   abstract protected function renderInput();
   abstract protected function getCustomControlClass();
 

src/view/form/control/select/AphrontFormSelectControl.php

@@ -48,7 +48,8 @@ class AphrontFormSelectControl extends AphrontFormControl {
     return phutil_render_tag(
       'select',
       array(
-        'name'    => $this->getName(),
+        'name'      => $this->getName(),
+        'disabled'  => $this->getDisabled() ? 'disabled' : null,
       ),
       implode("\n", $options));
   }

src/view/form/control/submit/AphrontFormSubmitControl.php

@@ -39,7 +39,8 @@ class AphrontFormSubmitControl extends AphrontFormControl {
     return phutil_render_tag(
       'button',
       array(
-        'name' => '__submit__',
+        'name'      => '__submit__',
+        'disabled'  => $this->getDisabled() ? 'disabled' : null,
       ),
       phutil_escape_html($this->getValue())).
       $this->cancelButton;

src/view/form/control/text/AphrontFormTextControl.php

@@ -26,9 +26,10 @@ class AphrontFormTextControl extends AphrontFormControl {
     return phutil_render_tag(
       'input',
       array(
-        'type'    => 'text',
+        'type'      => 'text',
-        'name'    => $this->getName(),
+        'name'      => $this->getName(),
-        'value'   => $this->getValue(),
+        'value'     => $this->getValue(),
+        'disabled'  => $this->getDisabled() ? 'disabled' : null,
       ));
   }
 

src/view/form/control/textarea/AphrontFormTextAreaControl.php

@@ -26,7 +26,8 @@ class AphrontFormTextAreaControl extends AphrontFormControl {
     return phutil_render_tag(
       'textarea',
       array(
-        'name'    => $this->getName(),
+        'name'      => $this->getName(),
+        'disabled'  => $this->getDisabled() ? 'disabled' : null,
       ),
       phutil_escape_html($this->getValue()));
   }

webroot/rsrc/css/base.css

@@ -476,6 +476,8 @@ a.small:visited {
   clear: both;
   margin-right: 25%;
   margin-left: 15%;
+  margin-top: 3px;
+  margin-bottom: 6px;
 }
 
 .aphront-error-view {