From 2c9a93eda7ddd88c26fd9fdc8b6174f1837a2716 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 25 Aug 2016 03:06:46 +0000 Subject: [PATCH] Fix app icons in homepage settings Summary: These were blank, from last week's shenanigans. Test Plan: View homepage settings, see icons. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16447 --- .../PhabricatorHomePreferencesSettingsPanel.php | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php b/src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php index 833a56deb7..fafe62ee4e 100644 --- a/src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php +++ b/src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php @@ -152,20 +152,12 @@ final class PhabricatorHomePreferencesSettingsPanel $icon = $application->getIcon(); if (!$icon) { - $icon = 'application'; + $icon = 'fa-globe'; } - $icon_view = javelin_tag( - 'span', - array( - 'class' => 'phui-icon-view phui-font-fa '.$icon, - 'aural' => false, - ), - ''); - $item = id(new PHUIObjectItemView()) ->setHeader($application->getName()) - ->setImageIcon($icon_view) + ->setImageIcon($icon) ->addAttribute($application->getShortDescription()) ->setGrippable(true);