Various linter fixes

Summary: Self explanatory.

Test Plan: `arc lint`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13863

src/aphront/configuration/AphrontApplicationConfiguration.php

@@ -246,13 +246,14 @@ abstract class AphrontApplicationConfiguration extends Phobject {
         if ($response instanceof AphrontWebpageResponse) {
           echo phutil_tag(
             'div',
-            array('style' =>
+            array(
-              'background: #eeddff;'.
+              'style' =>
-              'white-space: pre-wrap;'.
+                'background: #eeddff;'.
-              'z-index: 200000;'.
+                'white-space: pre-wrap;'.
-              'position: relative;'.
+                'z-index: 200000;'.
-              'padding: 8px;'.
+                'position: relative;'.
-              'font-family: monospace',
+                'padding: 8px;'.
+                'font-family: monospace',
             ),
             $unexpected_output);
         }

src/applications/conpherence/__tests__/ConpherenceTestCase.php

@@ -7,9 +7,10 @@ abstract class ConpherenceTestCase extends PhabricatorTestCase {
     ConpherenceThread $conpherence,
     array $participant_phids) {
 
-    $xactions = array(id(new ConpherenceTransaction())
+    $xactions = array(
-      ->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
+      id(new ConpherenceTransaction())
-      ->setNewValue(array('+' => $participant_phids)),
+        ->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
+        ->setNewValue(array('+' => $participant_phids)),
     );
     $editor = id(new ConpherenceEditor())
       ->setActor($actor)
@@ -23,9 +24,10 @@ abstract class ConpherenceTestCase extends PhabricatorTestCase {
     ConpherenceThread $conpherence,
     array $participant_phids) {
 
-    $xactions = array(id(new ConpherenceTransaction())
+    $xactions = array(
-      ->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
+      id(new ConpherenceTransaction())
-      ->setNewValue(array('-' => $participant_phids)),
+        ->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
+        ->setNewValue(array('-' => $participant_phids)),
     );
     $editor = id(new ConpherenceEditor())
       ->setActor($actor)

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

@@ -143,9 +143,10 @@ final class DifferentialCreateDiffConduitAPIMethod
       'unitStatus' => $unit_status,
     );
 
-    $xactions = array(id(new DifferentialTransaction())
+    $xactions = array(
-      ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
+      id(new DifferentialTransaction())
-      ->setNewValue($diff_data_dict),
+        ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
+        ->setNewValue($diff_data_dict),
     );
 
     id(new DifferentialDiffEditor())

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

@@ -51,9 +51,10 @@ final class DifferentialCreateRawDiffConduitAPIMethod
       'unitStatus' => DifferentialUnitStatus::UNIT_SKIP,
     );
 
-    $xactions = array(id(new DifferentialTransaction())
+    $xactions = array(
-      ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
+      id(new DifferentialTransaction())
-      ->setNewValue($diff_data_dict),
+        ->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
+        ->setNewValue($diff_data_dict),
     );
 
     if ($request->getValue('viewPolicy')) {

src/applications/differential/parser/DifferentialHunkParser.php

@@ -603,9 +603,9 @@ final class DifferentialHunkParser extends Phobject {
         $start = $start - $add_context;
         $end = $end + $add_context;
         $hunk_content = array();
-        $hunk_pos = array( '-' => 0, '+' => 0 );
+        $hunk_pos = array('-' => 0, '+' => 0);
-        $hunk_offset = array( '-' => null, '+' => null );
+        $hunk_offset = array('-' => null, '+' => null);
-        $hunk_last = array( '-' => null, '+' => null );
+        $hunk_last = array('-' => null, '+' => null);
         foreach (explode("\n", $hunk->getChanges()) as $line) {
           $in_common = strncmp($line, ' ', 1) === 0;
           $in_old = strncmp($line, '-', 1) === 0 || $in_common;

src/applications/home/controller/PhabricatorHomeMainController.php

@@ -219,7 +219,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
 
     $revisions = $revision_query->execute();
 
-    list($blocking, $active, ) = DifferentialRevisionQuery::splitResponsible(
+    list($blocking, $active,) = DifferentialRevisionQuery::splitResponsible(
         $revisions,
         array($user_phid));
 

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

@@ -67,9 +67,10 @@ final class PassphraseCredentialRevealController
         ->addCancelButton($view_uri, pht('Done'));
 
       $type_secret = PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET;
-      $xactions = array(id(new PassphraseCredentialTransaction())
+      $xactions = array(
-        ->setTransactionType($type_secret)
+        id(new PassphraseCredentialTransaction())
-        ->setNewValue(true),
+          ->setTransactionType($type_secret)
+          ->setNewValue(true),
       );
 
       $editor = id(new PassphraseCredentialTransactionEditor())

src/applications/project/controller/PhabricatorProjectColumnHideController.php

@@ -60,9 +60,10 @@ final class PhabricatorProjectColumnHideController
       }
 
       $type_status = PhabricatorProjectColumnTransaction::TYPE_STATUS;
-      $xactions = array(id(new PhabricatorProjectColumnTransaction())
+      $xactions = array(
-        ->setTransactionType($type_status)
+        id(new PhabricatorProjectColumnTransaction())
-        ->setNewValue($new_status),
+          ->setTransactionType($type_status)
+          ->setNewValue($new_status),
       );
 
       $editor = id(new PhabricatorProjectColumnTransactionEditor())

src/applications/search/engine/PhabricatorElasticSearchEngine.php

@@ -325,7 +325,7 @@ final class PhabricatorElasticSearchEngine extends PhabricatorSearchEngine {
     foreach ($types as $type) {
       // Use the custom trigram analyzer for the corpus of text
       $data['mappings'][$type]['properties']['field']['properties']['corpus'] =
-        array( 'type' => 'string', 'analyzer' => 'custom_trigrams' );
+        array('type' => 'string', 'analyzer' => 'custom_trigrams');
 
       // Ensure we have dateCreated since the default query requires it
       $data['mappings'][$type]['properties']['dateCreated']['type'] = 'string';

src/applications/uiexample/examples/PHUIButtonExample.php

@@ -68,7 +68,8 @@ final class PHUIButtonExample extends PhabricatorUIExample {
 
    // PHUIButtonView
 
-   $colors = array(null,
+   $colors = array(
+     null,
      PHUIButtonView::GREEN,
      PHUIButtonView::GREY,
      PHUIButtonView::DISABLED,

src/infrastructure/sms/worker/PhabricatorSMSWorker.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorSMSWorker
-  extends PhabricatorWorker {
+  extends PhabricatorWorker {}
-
-}

src/infrastructure/storage/lisk/__tests__/LiskChunkTestCase.php

@@ -4,8 +4,10 @@ final class LiskChunkTestCase extends PhabricatorTestCase {
 
   public function testSQLChunking() {
     $fragments = array(
-      'a', 'a',
+      'a',
-      'b', 'b',
+      'a',
+      'b',
+      'b',
       'ccc',
       'dd',
       'e',
@@ -23,7 +25,14 @@ final class LiskChunkTestCase extends PhabricatorTestCase {
 
 
     $fragments = array(
-      'a', 'a', 'a', 'XX', 'a', 'a', 'a', 'a',
+      'a',
+      'a',
+      'a',
+      'XX',
+      'a',
+      'a',
+      'a',
+      'a',
     );
 
     $this->assertEqual(
@@ -38,7 +47,9 @@ final class LiskChunkTestCase extends PhabricatorTestCase {
     $fragments = array(
       'xxxxxxxxxx',
       'yyyyyyyyyy',
-      'a', 'b', 'c',
+      'a',
+      'b',
+      'c',
       'zzzzzzzzzz',
     );
 

src/infrastructure/util/__tests__/PhabricatorHashTestCase.php

@@ -19,9 +19,23 @@ final class PhabricatorHashTestCase extends PhabricatorTestCase {
 
     // Test that the encoding produces 6 bits of entropy per byte.
     $entropy = array(
-      'dog', 'cat', 'rat', 'bat', 'dig', 'fig', 'cot',
+      'dog',
-      'cut', 'fog', 'rig', 'rug', 'dug', 'mat', 'pat',
+      'cat',
-      'eat', 'tar', 'pot',
+      'rat',
+      'bat',
+      'dig',
+      'fig',
+      'cot',
+      'cut',
+      'fog',
+      'rig',
+      'rug',
+      'dug',
+      'mat',
+      'pat',
+      'eat',
+      'tar',
+      'pot',
     );
 
     $seen = array();

src/view/AphrontDialogView.php

@@ -290,10 +290,11 @@ final class AphrontDialogView extends AphrontView {
     }
 
     if (!$this->renderAsForm) {
-      $buttons = array(phabricator_form(
+      $buttons = array(
-        $this->user,
+        phabricator_form(
-        $form_attributes,
+          $this->user,
-        array_merge($hidden_inputs, $buttons)),
+          $form_attributes,
+          array_merge($hidden_inputs, $buttons)),
       );
     }
 

src/view/__tests__/PhabricatorUnitsTestCase.php

@@ -55,7 +55,7 @@ final class PhabricatorUnitsTestCase extends PhabricatorTestCase {
   public function testDetailedDurationFormatting() {
     $expected_zero = 'now';
 
-    $tests = array (
+    $tests = array(
        12095939 => '19 w, 6 d',
       -12095939 => '19 w, 6 d ago',