From 2d5f3d9e5affd207efe3bfd87324240cabe24ed6 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Mon, 15 Jun 2015 18:01:09 +1000 Subject: [PATCH] Fix a pht string Summary: This translation string is wrong and causes the following warning when running unit tests: ``` [2015-06-15 16:03:41] ERROR 2: vsprintf(): Too few arguments at [/home/joshua/workspace/github.com/phacility/libphutil/src/internationalization/PhutilTranslator.php:95] arcanist(head=master, ref.master=956bfa701c36), phabricator(head=master, ref.master=80f11427e576), phutil(head=master, ref.master=3ff84448a916) #0 vsprintf(string, array) called at [/src/internationalization/PhutilTranslator.php:95] #1 PhutilTranslator::translate(string) #2 call_user_func_array(array, array) called at [/src/internationalization/pht.php:17] #3 pht(string) called at [/src/applications/auth/controller/PhabricatorAuthStartController.php:75] #4 PhabricatorAuthStartController::handleRequest(AphrontRequest) called at [/src/aphront/AphrontController.php:69] #5 AphrontController::delegateToController(PhabricatorAuthStartController) called at [/src/applications/base/controller/PhabricatorController.php:213] #6 PhabricatorController::willBeginExecution() called at [/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php:270] #7 PhabricatorAccessControlTestCase::checkAccess(string, PhabricatorTestController, AphrontRequest, array, array) called at [/src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php:112] #8 PhabricatorAccessControlTestCase::testControllerAccessControls() #9 call_user_func_array(array, array) called at [/src/unit/engine/phutil/PhutilTestCase.php:492] #10 PhutilTestCase::run() called at [/src/unit/engine/PhutilUnitTestEngine.php:65] #11 PhutilUnitTestEngine::run() called at [/src/workflow/ArcanistUnitWorkflow.php:186] #12 ArcanistUnitWorkflow::run() called at [/scripts/arcanist.php:382] ``` Test Plan: `arc lint` Reviewers: epriestley, #blessed_reviewers, chad Reviewed By: #blessed_reviewers, chad Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D13292 --- .../auth/controller/PhabricatorAuthStartController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/auth/controller/PhabricatorAuthStartController.php b/src/applications/auth/controller/PhabricatorAuthStartController.php index f9b9f7cb41..01578446a5 100644 --- a/src/applications/auth/controller/PhabricatorAuthStartController.php +++ b/src/applications/auth/controller/PhabricatorAuthStartController.php @@ -71,7 +71,7 @@ final class PhabricatorAuthStartController 'This Phabricator install is not configured with any enabled '. 'authentication providers which can be used to log in. If you '. 'have accidentally locked yourself out by disabling all providers, '. - 'you can use `%s` to recover access to an administrative account.'. + 'you can use `%s` to recover access to an administrative account.', 'phabricator/bin/auth recover ')); }