revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Remove getDisplayLine()

Browse source 
Summary: No callsites anywhere. Unclear what this method is even supposed to do.

Test Plan: grep

Reviewers: vrana, btrahan, jungejason

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D1435
This commit is contained in:
epriestley 2012-01-16 19:56:08 -08:00
parent 96c08a4f37
commit 2d8b35db93
1 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
View file

@ -242,24 +242,6 @@ class DifferentialChangesetParser {
} }
} }
public function getDisplayLine($offset, $length) {
$start = 1;
for ($ii = $offset; $ii > 0; $ii--) {
if ($this->new[$ii] && $this->new[$ii]['line']) {
$start = $this->new[$ii]['line'];
break;
}
}
$end = $start;
for ($ii = $offset + $length; $ii < count($this->new); $ii++) {
if ($this->new[$ii] && $this->new[$ii]['line']) {
$end = $this->new[$ii]['line'];
break;
}
}
return "{$start},{$end}";
}
public function parseInlineComment(DifferentialInlineComment $comment) { public function parseInlineComment(DifferentialInlineComment $comment) {
// Parse only comments which are actually visible. // Parse only comments which are actually visible.
if ($this->isCommentVisibleOnRenderedDiff($comment)) { if ($this->isCommentVisibleOnRenderedDiff($comment)) {