From 2de107f21b2c516dd1928257d9b58ad9efa27faf Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 14 Jan 2013 14:20:26 -0800 Subject: [PATCH] Remove DifferentialChangesetRenderer->(g|s)etLineCount() Summary: The "line count" is always the same as count($this->getOldLines()), and somewhat misleading since it's really "number of rows in the two-up view". D4421 removed the only (or only remaining?) call. Test Plan: looked at some diffs Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D4422 --- .../differential/parser/DifferentialChangesetParser.php | 1 - .../render/DifferentialChangesetRenderer.php | 9 --------- 2 files changed, 10 deletions(-) diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php index f190ab11b3..e4935e76e2 100644 --- a/src/applications/differential/parser/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/DifferentialChangesetParser.php @@ -694,7 +694,6 @@ final class DifferentialChangesetParser { $renderer = $this->getRenderer() ->setChangeset($this->changeset) ->setRenderPropertyChangeHeader($render_pch) - ->setLineCount($rows) ->setOldRender($this->oldRender) ->setNewRender($this->newRender) ->setHunkStartLines($this->hunkStartLines) diff --git a/src/applications/differential/render/DifferentialChangesetRenderer.php b/src/applications/differential/render/DifferentialChangesetRenderer.php index c03955792e..6424d96da9 100644 --- a/src/applications/differential/render/DifferentialChangesetRenderer.php +++ b/src/applications/differential/render/DifferentialChangesetRenderer.php @@ -27,15 +27,6 @@ abstract class DifferentialChangesetRenderer { private $gaps; private $mask; private $depths; - private $lineCount; - - public function setLineCount($line_count) { - $this->lineCount = $line_count; - return $this; - } - public function getLineCount() { - return $this->lineCount; - } public function setDepths($depths) { $this->depths = $depths;