revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 07:11:04 +01:00
Code Issues Releases Wiki Activity

Update continue/break for php 7.3

Browse source 
Summary:
Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236

I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the `break; break` was intentional or not, since I'm not sure you could ever reach two consecutive break statements.

Test Plan: Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19925
This commit is contained in:
Austin McKinley 2018-12-20 13:50:15 -08:00
parent c72d29f401
commit 2de632d4fe
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
View file

@ -55,12 +55,12 @@ final class PhabricatorProjectTransactionEditor
case PhabricatorProjectParentTransaction::TRANSACTIONTYPE:
case PhabricatorProjectMilestoneTransaction::TRANSACTIONTYPE:
if ($xaction->getNewValue() === null) {
continue;
continue 2;
}
if (!$parent_xaction) {
$parent_xaction = $xaction;
continue;
continue 2;
}
$errors[] = new PhabricatorApplicationTransactionValidationError(
@ -71,8 +71,7 @@ final class PhabricatorProjectTransactionEditor
'project or milestone project. A project can not be both a '.
'subproject and a milestone.'),
$xaction);
break;
break;
break 2;
}
}