mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-26 08:42:41 +01:00
Fix an issue where projects queried in "Any Projects" in Maniphest did not have their handles loaded
Summary: See https://github.com/facebook/phabricator/issues/230. If you searched for a project with the "Any Projects" field, we didn't explicitly include it in the list of handles to fetch. Usually this works fine because something else fetches the handle, but if you, e.g., search for a project that has no tasks, you get a fatal. Test Plan: Reproduced fatal described in report by performing a custom query for "Any Projects" using a project with no tasks; applied patch; query worked correctly. Verified `$xproject_phids` and `$project_phids` are already queried. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3923
This commit is contained in:
parent
c812d7d686
commit
2e993f7561
1 changed files with 1 additions and 0 deletions
|
@ -543,6 +543,7 @@ final class ManiphestTaskListController extends ManiphestController {
|
||||||
$owner_phids,
|
$owner_phids,
|
||||||
$author_phids,
|
$author_phids,
|
||||||
$project_group_phids,
|
$project_group_phids,
|
||||||
|
$any_project_phids,
|
||||||
array_mergev(mpull($data, 'getProjectPHIDs')));
|
array_mergev(mpull($data, 'getProjectPHIDs')));
|
||||||
$handles = id(new PhabricatorObjectHandleData($handle_phids))
|
$handles = id(new PhabricatorObjectHandleData($handle_phids))
|
||||||
->loadHandles();
|
->loadHandles();
|
||||||
|
|
Loading…
Reference in a new issue