From 2ed29980dbadcb51f29dc3f22ab2c442780f8616 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 30 Apr 2013 10:54:02 -0700 Subject: [PATCH] Make DiffusionQuery extend PhabricatorQuery Summary: Ref T2683. Provides access to `formatWhereClause()`, etc. I plan to eventually unify the various DiffusionQuery execute methods as well, which all have special names right now (`loadModifiedPaths()`, `loadWhateverBlah()`, etc). Test Plan: Ran EverythingImplemented test. Browsed Diffusion. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2683 Differential Revision: https://secure.phabricator.com/D5251 --- src/__phutil_library_map__.php | 1 + src/applications/diffusion/query/DiffusionQuery.php | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 1ffb93ec11..84c76de72b 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -2224,6 +2224,7 @@ phutil_register_library_map(array( 'DiffusionPathQueryTestCase' => 'PhabricatorTestCase', 'DiffusionPathValidateController' => 'DiffusionController', 'DiffusionPeopleMenuEventListener' => 'PhutilEventListener', + 'DiffusionQuery' => 'PhabricatorQuery', 'DiffusionRawDiffQuery' => 'DiffusionQuery', 'DiffusionRemarkupRule' => 'PhabricatorRemarkupRuleObject', 'DiffusionRepositoryController' => 'DiffusionController', diff --git a/src/applications/diffusion/query/DiffusionQuery.php b/src/applications/diffusion/query/DiffusionQuery.php index d902587de4..24120ce0f0 100644 --- a/src/applications/diffusion/query/DiffusionQuery.php +++ b/src/applications/diffusion/query/DiffusionQuery.php @@ -1,6 +1,6 @@ request; } + public function execute() { + return $this->executeQuery(); + } + abstract protected function executeQuery();