Simplify implementation of "SysetemAction->getSystemActionConstant()"

Summary: Depends on D20668. Ref T13343. Just an easy cleanup/simplification while I'm here.

Test Plan: `grep` for `getActionConstant()`

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13343

Differential Revision: https://secure.phabricator.com/D20669

src/applications/auth/action/PhabricatorAuthChangePasswordAction.php

@@ -5,10 +5,6 @@ final class PhabricatorAuthChangePasswordAction
 
   const TYPECONST = 'auth.password';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 20 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthEmailLoginAction.php

@@ -4,10 +4,6 @@ final class PhabricatorAuthEmailLoginAction extends PhabricatorSystemAction {
 
   const TYPECONST = 'mail.login';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 3 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthNewFactorAction.php

@@ -4,10 +4,6 @@ final class PhabricatorAuthNewFactorAction extends PhabricatorSystemAction {
 
   const TYPECONST = 'auth.factor.new';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 60 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

@@ -4,10 +4,6 @@ final class PhabricatorAuthTestSMSAction extends PhabricatorSystemAction {
 
   const TYPECONST = 'auth.sms.test';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 60 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php

@@ -5,10 +5,6 @@ final class PhabricatorAuthTryEmailLoginAction
 
   const TYPECONST = 'mail.try-login';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 20 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthTryFactorAction.php

@@ -4,10 +4,6 @@ final class PhabricatorAuthTryFactorAction extends PhabricatorSystemAction {
 
   const TYPECONST = 'auth.factor';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 10 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthTryPasswordAction.php

@@ -5,10 +5,6 @@ final class PhabricatorAuthTryPasswordAction
 
   const TYPECONST = 'auth.password';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 100 / phutil_units('1 hour in seconds');
   }

src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

@@ -5,10 +5,6 @@ final class PhabricatorAuthTryPasswordWithoutCAPTCHAAction
 
   const TYPECONST = 'auth.password-without-captcha';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 10 / phutil_units('1 hour in seconds');
   }

src/applications/files/action/PhabricatorFilesOutboundRequestAction.php

@@ -5,10 +5,6 @@ final class PhabricatorFilesOutboundRequestAction
 
   const TYPECONST = 'files.outbound';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 60 / phutil_units('1 hour in seconds');
   }

src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php

@@ -2,9 +2,7 @@
 
 final class PhabricatorMetaMTAErrorMailAction extends PhabricatorSystemAction {
 
-  public function getActionConstant() {
-    return 'email.error';
-  }
+  const TYPECONST = 'email.error';
 
   public function getScoreThreshold() {
     return 6 / phutil_units('1 hour in seconds');

src/applications/phortune/action/PhortuneAddPaymentMethodAction.php

@@ -5,10 +5,6 @@ final class PhortuneAddPaymentMethodAction
 
   const TYPECONST = 'phortune.payment-method.add';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 60 / phutil_units('1 hour in seconds');
   }

src/applications/settings/action/PhabricatorSettingsAddEmailAction.php

@@ -4,10 +4,6 @@ final class PhabricatorSettingsAddEmailAction extends PhabricatorSystemAction {
 
   const TYPECONST = 'email.add';
 
-  public function getActionConstant() {
-    return self::TYPECONST;
-  }
-
   public function getScoreThreshold() {
     return 6 / phutil_units('1 hour in seconds');
   }

src/applications/system/action/PhabricatorSystemAction.php

@@ -2,7 +2,10 @@
 
 abstract class PhabricatorSystemAction extends Phobject {
 
-  abstract public function getActionConstant();
+  final public function getActionConstant() {
+    return $this->getPhobjectClassConstant('TYPECONST', 32);
+  }
+
   abstract public function getScoreThreshold();
 
   public function shouldBlockActor($actor, $score) {