From 2efd8fe97125c531cd9104c1d07a520dcf795a53 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Dec 2011 18:28:35 -0800 Subject: [PATCH] Fix a bad %d for PHID Summary: D1174 caught this issue -- we mean to load all //your// rules, but actually load //all// rules. Use %s correctly. Test Plan: Hit /herald/rule/ without an exception. Reviewers: fmoo, btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Differential Revision: 1203 --- .../herald/controller/rule/HeraldRuleController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/controller/rule/HeraldRuleController.php b/src/applications/herald/controller/rule/HeraldRuleController.php index 789e5d478b..67de87388d 100644 --- a/src/applications/herald/controller/rule/HeraldRuleController.php +++ b/src/applications/herald/controller/rule/HeraldRuleController.php @@ -376,7 +376,7 @@ class HeraldRuleController extends HeraldController { } $all_rules = id(new HeraldRule())->loadAllWhere( - 'authorPHID = %d AND contentType = %s', + 'authorPHID = %s AND contentType = %s', $rule->getAuthorPHID(), $rule->getContentType()); $all_rules = mpull($all_rules, 'getName', 'getID');