From 2f1e271c5fd7017168ec65f86bbef46075ec7558 Mon Sep 17 00:00:00 2001
From: Benjamin Kausch <b.kausch@kids-interactive.de>
Date: Mon, 22 Jan 2024 09:14:47 +0100
Subject: [PATCH] Remove bottom margin from embedded remarkup images

Summary:
{T15473} created a very small but annoying regression. Every embedded images has now an margin at the bottom:

{F718091}

I don't think this is intentional. If you click on the margin the image itself is opened not the lightbox. This revision removes the margin.

Test Plan: Look at tasks with embedded images and see if there is still an margin.

Reviewers: O1 Blessed Committers, valerio.bozzolan, aklapper

Reviewed By: O1 Blessed Committers, valerio.bozzolan, aklapper

Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25522
---
 resources/celerity/map.php                        | 10 +++++-----
 webroot/rsrc/css/core/remarkup.css                |  8 ++++++++
 webroot/rsrc/css/phui/phui-property-list-view.css |  7 ++-----
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 18806d504b..43b5f64503 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '2f25eb4f',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => '5e7dbeb9',
+    'core.pkg.css' => '3b2df0d0',
     'core.pkg.js' => '2eeda9e0',
     'dark-console.pkg.js' => '187792c2',
     'differential.pkg.css' => '2431def2',
@@ -109,7 +109,7 @@ return array(
     'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd',
     'rsrc/css/application/uiexample/example.css' => 'b4795059',
     'rsrc/css/core/core.css' => 'b3a5928e',
-    'rsrc/css/core/remarkup.css' => '3480e1fe',
+    'rsrc/css/core/remarkup.css' => 'b251d2e7',
     'rsrc/css/core/syntax.css' => '548567f6',
     'rsrc/css/core/z-index.css' => 'ac3bfcd4',
     'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
@@ -171,7 +171,7 @@ return array(
     'rsrc/css/phui/phui-pager.css' => 'd022c7ad',
     'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8',
     'rsrc/css/phui/phui-policy-section-view.css' => '139fdc64',
-    'rsrc/css/phui/phui-property-list-view.css' => '118db252',
+    'rsrc/css/phui/phui-property-list-view.css' => '9a155095',
     'rsrc/css/phui/phui-remarkup-preview.css' => '91767007',
     'rsrc/css/phui/phui-segment-bar-view.css' => '5166b370',
     'rsrc/css/phui/phui-spacing.css' => 'b05cadc3',
@@ -798,7 +798,7 @@ return array(
     'phabricator-object-selector-css' => 'ee77366f',
     'phabricator-phtize' => '2f1db1ed',
     'phabricator-prefab' => '5793d835',
-    'phabricator-remarkup-css' => '3480e1fe',
+    'phabricator-remarkup-css' => 'b251d2e7',
     'phabricator-remarkup-metadata' => 'e40c4991',
     'phabricator-search-results-css' => '9ea70ace',
     'phabricator-shaped-request' => '995f5102',
@@ -873,7 +873,7 @@ return array(
     'phui-pager-css' => 'd022c7ad',
     'phui-pinboard-view-css' => '1f08f5d8',
     'phui-policy-section-view-css' => '139fdc64',
-    'phui-property-list-view-css' => '118db252',
+    'phui-property-list-view-css' => '9a155095',
     'phui-remarkup-preview-css' => '91767007',
     'phui-segment-bar-view-css' => '5166b370',
     'phui-spacing-css' => 'b05cadc3',
diff --git a/webroot/rsrc/css/core/remarkup.css b/webroot/rsrc/css/core/remarkup.css
index 7f1c51cac9..76554b56b4 100644
--- a/webroot/rsrc/css/core/remarkup.css
+++ b/webroot/rsrc/css/core/remarkup.css
@@ -474,6 +474,14 @@ video.phabricator-media {
   box-shadow: 1px 1px 2px rgba({$alphablack}, 0.20);
 }
 
+.phabricator-remarkup-embed-image > img {
+  background: url('/rsrc/image/checker_light.png');
+}
+
+.device-desktop .phabricator-remarkup-embed-image > img:hover {
+  background: url('/rsrc/image/checker_dark.png');
+}
+
 .phabricator-remarkup-embed-image-full,
 .phabricator-remarkup-embed-image-wide {
   display: inline-block;
diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css
index 93388c3d7c..7a5512e6f2 100644
--- a/webroot/rsrc/css/phui/phui-property-list-view.css
+++ b/webroot/rsrc/css/phui/phui-property-list-view.css
@@ -203,16 +203,13 @@ div.phui-property-list-stacked .phui-property-list-properties
   border-bottom: 1px solid {$blueborder};
 }
 
-
-.document-engine-image img,
-.phabricator-remarkup-embed-image img {
+.document-engine-image img {
   margin: 20px auto;
   background: url('/rsrc/image/checker_light.png');
   max-width: 100%;
 }
 
-.device-desktop .document-engine-image img:hover,
-.device-desktop .phabricator-remarkup-embed-image img:hover {
+.device-desktop .document-engine-image img:hover {
   background: url('/rsrc/image/checker_dark.png');
 }