mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-20 13:52:40 +01:00
Preserve linebreaks again in Summary / Test Plan for revisions
Summary: I pulled these into the property list recently, which made them more consistent, but that dropped "preserve linebreaks". Since these usually come from the CLI, render with linebreaks preserved. @csilvers, you'll need to `bin/cache purge --purge-remarkup` after this if you want to fix existing revisions. Test Plan: Made a revision with some poetry, saw poetry preserved. Reviewers: btrahan, csilvers Reviewed By: btrahan CC: csilvers, aran Differential Revision: https://secure.phabricator.com/D7464
This commit is contained in:
parent
2250ee6aa6
commit
2f7057ad99
1 changed files with 6 additions and 4 deletions
|
@ -118,8 +118,9 @@ final class DifferentialRevisionDetailView extends AphrontView {
|
||||||
$properties->addSectionHeader(pht('Summary'));
|
$properties->addSectionHeader(pht('Summary'));
|
||||||
$properties->addTextContent(
|
$properties->addTextContent(
|
||||||
PhabricatorMarkupEngine::renderOneObject(
|
PhabricatorMarkupEngine::renderOneObject(
|
||||||
id(new PhabricatorMarkupOneOff())->setContent(
|
id(new PhabricatorMarkupOneOff())
|
||||||
$revision->getSummary()),
|
->setPreserveLinebreaks(true)
|
||||||
|
->setContent($revision->getSummary()),
|
||||||
'default',
|
'default',
|
||||||
$user));
|
$user));
|
||||||
}
|
}
|
||||||
|
@ -128,8 +129,9 @@ final class DifferentialRevisionDetailView extends AphrontView {
|
||||||
$properties->addSectionHeader(pht('Test Plan'));
|
$properties->addSectionHeader(pht('Test Plan'));
|
||||||
$properties->addTextContent(
|
$properties->addTextContent(
|
||||||
PhabricatorMarkupEngine::renderOneObject(
|
PhabricatorMarkupEngine::renderOneObject(
|
||||||
id(new PhabricatorMarkupOneOff())->setContent(
|
id(new PhabricatorMarkupOneOff())
|
||||||
$revision->getTestPlan()),
|
->setPreserveLinebreaks(true)
|
||||||
|
->setContent($revision->getTestPlan()),
|
||||||
'default',
|
'default',
|
||||||
$user));
|
$user));
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue