revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-20 11:41:08 +01:00
Code Issues Releases Wiki Activity

Oversight: Prevent deletion/movement of stub pages

Browse source 
Summary: Refs T2686 - Now you also can't delete / move stubbed pages

Test Plan: tried it out - works wonderful

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2686

Differential Revision: https://secure.phabricator.com/D5341
This commit is contained in:
Anh Nhan Nguyen 2013-03-14 06:20:35 -07:00 committed by epriestley
parent 76ed21d922
commit 2f9c981716
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/phriction/controller/PhrictionDeleteController.php
View file

@ -25,6 +25,7 @@ final class PhrictionDeleteController extends PhrictionController {
$disallowed_states = array( $disallowed_states = array(
PhrictionDocumentStatus::STATUS_DELETED, // Stupid PhrictionDocumentStatus::STATUS_DELETED, // Stupid
PhrictionDocumentStatus::STATUS_MOVED, // Makes no sense PhrictionDocumentStatus::STATUS_MOVED, // Makes no sense
PhrictionDocumentStatus::STATUS_STUB, // How could they?
); );
if (in_array($document->getStatus(), $disallowed_states)) { if (in_array($document->getStatus(), $disallowed_states)) {
$e_text = pht('An already moved or deleted document can not be deleted'); $e_text = pht('An already moved or deleted document can not be deleted');

1
src/applications/phriction/controller/PhrictionMoveController.php
View file

@ -53,6 +53,7 @@ final class PhrictionMoveController
$disallowed_statuses = array( $disallowed_statuses = array(
PhrictionDocumentStatus::STATUS_DELETED, // Stupid PhrictionDocumentStatus::STATUS_DELETED, // Stupid
PhrictionDocumentStatus::STATUS_MOVED, // Plain stupid PhrictionDocumentStatus::STATUS_MOVED, // Plain stupid
PhrictionDocumentStatus::STATUS_STUB, // Utterly stupid
); );
if (in_array($document->getStatus(), $disallowed_statuses)) { if (in_array($document->getStatus(), $disallowed_statuses)) {
$error_view = new AphrontErrorView(); $error_view = new AphrontErrorView();