revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Fourth fix for the magical world of crumbs and text-overflow

Browse source 
Summary: The Safari hack in place casued a truncation issue in Firefox, so that hack is now gone. Instead the bug appears to be the creative inclusion of "space". In fiddling with this adding one space inside the span and one space outside the span seems to resolve all cases.

Test Plan: Chrome, Safari, Firefox. Test "hector" and copy paste of a Task ID.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17483
This commit is contained in:
Chad Little 2017-03-08 17:52:57 -08:00
parent abff6dc8a9
commit 2fed5b6925
3 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -9,7 +9,7 @@ return array(
'names' => array( 'names' => array(
'conpherence.pkg.css' => '6875302f', 'conpherence.pkg.css' => '6875302f',
'conpherence.pkg.js' => '6249a1cf', 'conpherence.pkg.js' => '6249a1cf',
'core.pkg.css' => '7e10ec60', 'core.pkg.css' => 'db710bcc',
'core.pkg.js' => '1fa7c0c5', 'core.pkg.js' => '1fa7c0c5',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '90b30783', 'differential.pkg.css' => '90b30783',
@ -139,7 +139,7 @@ return array(
'rsrc/css/phui/phui-cms.css' => '504b4b23', 'rsrc/css/phui/phui-cms.css' => '504b4b23',
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d', 'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad', 'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
'rsrc/css/phui/phui-crumbs-view.css' => 'ccbf2a0c', 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4', 'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4',
'rsrc/css/phui/phui-document-pro.css' => 'f56738ed', 'rsrc/css/phui/phui-document-pro.css' => 'f56738ed',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf', 'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
@ -850,7 +850,7 @@ return array(
'phui-cms-css' => '504b4b23', 'phui-cms-css' => '504b4b23',
'phui-comment-form-css' => '48fbd65d', 'phui-comment-form-css' => '48fbd65d',
'phui-comment-panel-css' => 'f50152ad', 'phui-comment-panel-css' => 'f50152ad',
'phui-crumbs-view-css' => 'ccbf2a0c', 'phui-crumbs-view-css' => '6ece3bbb',
'phui-curtain-view-css' => '947bf1a4', 'phui-curtain-view-css' => '947bf1a4',
'phui-document-summary-view-css' => '9ca48bdf', 'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'c32e8dec', 'phui-document-view-css' => 'c32e8dec',

6
src/view/phui/PHUICrumbView.php
View file

@ -75,7 +75,7 @@ final class PHUICrumbView extends AphrontView {
// Surround the crumb name with spaces so that double clicking it only // Surround the crumb name with spaces so that double clicking it only
// selects the crumb itself. // selects the crumb itself.
$name = array(' ', $this->name, ' '); $name = array(' ', $this->name);
$name = phutil_tag( $name = phutil_tag(
'span', 'span',
@ -84,6 +84,10 @@ final class PHUICrumbView extends AphrontView {
), ),
$name); $name);
// Because of text-overflow and safari, put the second space on the
// outside of the element.
$name = array($name, ' ');
$divider = null; $divider = null;
if (!$this->isLastCrumb) { if (!$this->isLastCrumb) {
$divider = id(new PHUIIconView()) $divider = id(new PHUIIconView())

7
webroot/rsrc/css/phui/phui-crumbs-view.css
View file

@ -54,13 +54,6 @@
text-overflow: ellipsis; text-overflow: ellipsis;
} }
/* Safari Hack, See D17361 */
.phui-crumb-view:after {
content: "\0000a0";
display: inline-block;
width: 0;
}
.device-phone .phui-crumb-view.phabricator-last-crumb .phui-crumb-name, .device-phone .phui-crumb-view.phabricator-last-crumb .phui-crumb-name,
.device-phone .phui-crumb-view.phui-crumb-has-icon, .device-phone .phui-crumb-view.phui-crumb-has-icon,
.device-phone .phui-crumb-has-icon + .phui-crumb-divider { .device-phone .phui-crumb-has-icon + .phui-crumb-divider {