From 301c7d0a146704f024759f474a8cf49f1fb1e423 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 29 Apr 2014 10:57:10 -0700 Subject: [PATCH] Require the "ctype" extension explicitly Summary: Fixes T4916. Although every normal build of PHP has this in the core, at least one distribution which users could reasonably encounter does not. Test Plan: Changed string to "ctypex", got setup warning. Changed to "ctype", got no warning. Reviewers: hach-que, btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4916 Differential Revision: https://secure.phabricator.com/D8896 --- .../config/check/PhabricatorSetupCheckExtensions.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/config/check/PhabricatorSetupCheckExtensions.php b/src/applications/config/check/PhabricatorSetupCheckExtensions.php index 87f1bcd6dd..89ad012adf 100644 --- a/src/applications/config/check/PhabricatorSetupCheckExtensions.php +++ b/src/applications/config/check/PhabricatorSetupCheckExtensions.php @@ -16,6 +16,7 @@ final class PhabricatorSetupCheckExtensions extends PhabricatorSetupCheck { 'openssl', 'mbstring', 'iconv', + 'ctype', // There is a chance we might not need this, but some configurations (like // OAuth or Amazon SES) will require it. Just mark it 'required' since