From 30ffe0ce5d994555c1e16331522700cd55514c65 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 13 Feb 2014 10:05:47 -0800 Subject: [PATCH] Bump number of visible Maniphest tags to 4 (from 2) Summary: Ref T3574. Since this list just clips in a totally reasonable way on mobile and we got another user request for it, let's bump this to 4 for now and we can refine mobile later. Test Plan: Looked at list on desktop; saw 4 tags before truncation. Looked at list on mobile, saw reasonable clipping behavior which didn't mar usability. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3574 Differential Revision: https://secure.phabricator.com/D8213 --- .../maniphest/view/ManiphestTaskProjectsView.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/maniphest/view/ManiphestTaskProjectsView.php b/src/applications/maniphest/view/ManiphestTaskProjectsView.php index 419b082ce0..3ce8d08d99 100644 --- a/src/applications/maniphest/view/ManiphestTaskProjectsView.php +++ b/src/applications/maniphest/view/ManiphestTaskProjectsView.php @@ -15,9 +15,9 @@ final class ManiphestTaskProjectsView extends ManiphestView { public function render() { require_celerity_resource('phabricator-project-tag-css'); + $max_visible_tags = 4; - - $show = array_slice($this->handles, 0, 2); + $show = array_slice($this->handles, 0, $max_visible_tags); $tags = array(); if ($show) { @@ -39,7 +39,7 @@ final class ManiphestTaskProjectsView extends ManiphestView { pht('No Project')); } - if (count($this->handles) > 2) { + if (count($this->handles) > $max_visible_tags) { require_celerity_resource('aphront-tooltip-css'); Javelin::initBehavior('phabricator-tooltips');