Undo D6266 (DifferentialComment PHID migration)

Summary:
Ref T2222. My path forward here wasn't very good -- I was thinking I could set `transactionPHID` for the inline comments as I migrated, but it must be unique and an individual DifferentialComment may have more than one inline comment. Dropping the unique requirement just creates more issues for us, not fewer.

So the migration in D6266 isn't actually useful. Undo it -- this can't be a straight revert because some installs may already have upgraded.

Test Plan: Ran new migrations, verified the world ended up back in the same place as before (made comments, viewed reivsions).

Reviewers: btrahan

Reviewed By: btrahan

CC: wez, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D6269

resources/sql/patches/20130621.diffcommentphidmig.php

@@ -1,23 +1,3 @@
 <?php
 
-$conn = id(new DifferentialRevision())->establishConnection('r');
+// This patch is unnecessary and was nuked.
-
-echo "Assigning transaction PHIDs to DifferentialComments.\n";
-foreach (new LiskRawMigrationIterator($conn, 'differential_comment') as $row) {
-  $id = $row['id'];
-  echo "Migrating comment #{$id}...\n";
-  if ($row['phid']) {
-    continue;
-  }
-
-  queryfx(
-    $conn,
-    'UPDATE %T SET phid = %s WHERE id = %d',
-    'differential_comment',
-    PhabricatorPHID::generateNewPHID(
-      PhabricatorPHIDConstants::PHID_TYPE_XACT,
-      PhabricatorPHIDConstants::PHID_TYPE_DREV),
-    $id);
-}
-
-echo "Done.\n";

resources/sql/patches/20130621.diffcommentunphid.sql

@@ -0,0 +1,5 @@
+ALTER TABLE {$NAMESPACE}_differential.differential_comment
+  DROP phid;
+
+ALTER TABLE {$NAMESPACE}_differential.differential_transaction_comment
+  ADD legacyCommentID INT UNSIGNED;

src/applications/differential/storage/DifferentialComment.php

@@ -20,12 +20,6 @@ final class DifferentialComment extends DifferentialDAO
 
   private $arbitraryDiffForFacebook;
 
-  public function generatePHID() {
-    return PhabricatorPHID::generateNewPHID(
-      PhabricatorPHIDConstants::PHID_TYPE_XACT,
-      PhabricatorPHIDConstants::PHID_TYPE_DREV);
-  }
-
   public function giveFacebookSomeArbitraryDiff(DifferentialDiff $diff) {
     $this->arbitraryDiffForFacebook = $diff;
     return $this;
@@ -33,7 +27,6 @@ final class DifferentialComment extends DifferentialDAO
 
   public function getConfiguration() {
     return array(
-      self::CONFIG_AUX_PHID => true,
       self::CONFIG_SERIALIZATION => array(
         'metadata' => self::SERIALIZATION_JSON,
       ),

src/applications/differential/storage/DifferentialTransactionComment.php

@@ -11,6 +11,7 @@ final class DifferentialTransactionComment
   protected $fixedState;
   protected $hasReplies = 0;
   protected $replyToCommentPHID;
+  protected $legacyCommentID;
 
   public function getApplicationTransactionObject() {
     return new DifferentialTransaction();

src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

@@ -1390,6 +1390,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList {
         'type' => 'php',
         'name' => $this->getPatchPath('20130621.diffcommentphidmig.php'),
       ),
+      '20130621.diffcommentunphid.sql' => array(
+        'type' => 'sql',
+        'name' => $this->getPatchPath('20130621.diffcommentunphid.sql'),
+      ),
     );
   }
 }