revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fix email for closing a blocking task

Browse source 
Summary: Fixes T5751. Currently, we incorrectly overwrite `$xactions`.

Test Plan: Closed a blocking task, got an email about the correct transaction set ("closed task; added comment") instead of an overwritten transaction set ("closed blocking task").

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5751

Differential Revision: https://secure.phabricator.com/D10088
This commit is contained in:
epriestley 2014-07-30 17:12:28 -07:00
parent de40cf5ef7
commit 31343e61ce
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/maniphest/editor/ManiphestTransactionEditor.php
View file

@ -258,9 +258,9 @@ final class ManiphestTransactionEditor
$new = $unblock_xaction->getNewValue(); $new = $unblock_xaction->getNewValue();
foreach ($blocked_tasks as $blocked_task) { foreach ($blocked_tasks as $blocked_task) {
$xactions = array(); $unblock_xactions = array();
$xactions[] = id(new ManiphestTransaction()) $unblock_xactions[] = id(new ManiphestTransaction())
->setTransactionType(ManiphestTransaction::TYPE_UNBLOCK) ->setTransactionType(ManiphestTransaction::TYPE_UNBLOCK)
->setOldValue(array($object->getPHID() => $old)) ->setOldValue(array($object->getPHID() => $old))
->setNewValue(array($object->getPHID() => $new)); ->setNewValue(array($object->getPHID() => $new));
@ -275,7 +275,7 @@ final class ManiphestTransactionEditor
->setContentSource($this->getContentSource()) ->setContentSource($this->getContentSource())
->setContinueOnNoEffect(true) ->setContinueOnNoEffect(true)
->setContinueOnMissingFields(true) ->setContinueOnMissingFields(true)
->applyTransactions($blocked_task, $xactions); ->applyTransactions($blocked_task, $unblock_xactions);
} }
} }
} }