From 314e7266c3e5b071cb6e916d28c21cb143d6e013 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 14 Nov 2017 12:06:24 -0800 Subject: [PATCH] Restore "Summary" and "Test Plan" to initial mail for non-draft configurations Summary: See PHI210. Ref T2543. Currently, we don't set this flag if you have prototypes off and don't get any of the new draft stuff, so the mail drops some of the details it is supposed to have. Test Plan: Disabled prototypes, created a revision, saw summary / test plan in the initial mail. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18771 --- .../differential/editor/DifferentialTransactionEditor.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index 26c440e866..7cea29359f 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -1612,6 +1612,13 @@ final class DifferentialTransactionEditor $xactions[] = $xaction; } + } else { + // If this revision is being created into some state other than "Draft", + // this is the first broadcast and should include sections like "SUMMARY" + // and "TEST PLAN". + if ($this->getIsNewObject()) { + $this->firstBroadcast = true; + } } return $xactions;