revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 13:52:40 +01:00
Code Issues Releases Wiki Activity

Use %B for Harbormaster build log updates as well

Browse source 
Summary: So I derped and missed the %s inside the `UPDATE` query (previously only fixing the `INSERT` query).  This changes `%s` to `%B` for the update logic as well.

Test Plan: Patched it in production and saw the offending build run all the way through without UTF8-related exceptions.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11669
This commit is contained in:
James Rhodes 2015-02-03 22:59:29 +00:00
parent e6fb1dc1e9
commit 32488687e7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
View file

@ -133,7 +133,7 @@ final class HarbormasterBuildLog extends HarbormasterDAO
queryfx( queryfx(
$conn, $conn,
'UPDATE harbormaster_buildlogchunk '. 'UPDATE harbormaster_buildlogchunk '.
'SET chunk = CONCAT(chunk, %s), size = LENGTH(CONCAT(chunk, %s))'. 'SET chunk = CONCAT(chunk, %B), size = LENGTH(CONCAT(chunk, %B))'.
'WHERE id = %d', 'WHERE id = %d',
$content, $content,
$content, $content,