revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-04 11:51:02 +01:00
Code Issues Releases Wiki Activity

Fix rendering issue for LDAP configuration provider transactions

Browse source 
Summary: Fixes T4290. At least one of the fields (`realname`) may have a list of items, and `strlen(array('first', 'last'))` produces the warning and stack trace in T4290.

Test Plan:
  - Edited `realname` from an array value to an array value.
  - Hit error.
  - Applied patch.
  - No more error.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4290

Differential Revision: https://secure.phabricator.com/D7905
This commit is contained in:
epriestley 2014-01-08 13:27:08 -08:00
parent 1cb8f0b393
commit 324ee4e4d5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
View file

@ -361,7 +361,7 @@ final class PhabricatorAuthProviderLDAP
$label); $label);
} }
if (!strlen($old)) { if ($old === null || $old === '') {
return pht( return pht(
'%s set the "%s" value to "%s".', '%s set the "%s" value to "%s".',
$xaction->renderHandleLink($author_phid), $xaction->renderHandleLink($author_phid),