mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
In commit history list view, show all commits
Summary: Currently, the last group of commits is not shown in the list view because the final `$list` is never added to `$view`. For example, if the first page would contain commits from "April 7", "April 6", and "April 5", commits from "April 5" are not shown. (If a repository has 100 commits in a single day, nothing is shown.) On this server, here's the bottom of page 1: {F4987087} Here's the top of page 2: {F4987088} However, here's `git log` between those commits: ``` $ git log --oneline 7e46^..5f49f5f49f9c793
Add sound to logged out Conpherence1644b45050
Disperse task subpriorities in blocksc6a7bcfe89
Make Pholio description behave as a remarkup field (e.g., subscribe mentioned users)bbc5f79227
Make membership lock/unlock feed stories read more naturally789d57522b
Make editing project images redirect to "Manage" more consistently10b3879232
Make Project slug/hashtag transactions render a little more nicelyabd791889c
Update Maniphest title transaction again5a34b299e4
Update Maniphest title language601622013d
Clarify milestone/subproject creation languagec9889e3d55
Fix an issue in Phriction where moving a document just copied it insteadfdf00f6df4
Clean up some minor UI behaviors in Differential6c46f27d98
Add quest objectives to the minimapd783299a19
Fix Phriction status not set property on new document93e28da76e
Add more "disabled" UI to PHUIObjectItemView7e46d7ab6a
Migrate Project color to modular transactions ``` This group of commits does not currently appear anywhere in the list. Test Plan: Viewed a page of commits, saw 100 commits. Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D18066
This commit is contained in:
parent
d42d69aef6
commit
335c3a7d12
1 changed files with 5 additions and 7 deletions
|
@ -26,19 +26,12 @@ final class DiffusionHistoryListView extends DiffusionHistoryView {
|
|||
$rows = array();
|
||||
$ii = 0;
|
||||
$cur_date = 0;
|
||||
$list = null;
|
||||
$header = null;
|
||||
$view = array();
|
||||
foreach ($this->getHistory() as $history) {
|
||||
$epoch = $history->getEpoch();
|
||||
$new_date = date('Ymd', $history->getEpoch());
|
||||
if ($cur_date != $new_date) {
|
||||
if ($list) {
|
||||
$view[] = id(new PHUIObjectBoxView())
|
||||
->setHeader($header)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->setObjectList($list);
|
||||
}
|
||||
$date = ucfirst(
|
||||
phabricator_relative_date($history->getEpoch(), $viewer));
|
||||
$header = id(new PHUIHeaderView())
|
||||
|
@ -46,6 +39,11 @@ final class DiffusionHistoryListView extends DiffusionHistoryView {
|
|||
$list = id(new PHUIObjectItemListView())
|
||||
->setFlush(true)
|
||||
->addClass('diffusion-history-list');
|
||||
|
||||
$view[] = id(new PHUIObjectBoxView())
|
||||
->setHeader($header)
|
||||
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
||||
->setObjectList($list);
|
||||
}
|
||||
|
||||
if ($epoch) {
|
||||
|
|
Loading…
Reference in a new issue