Extend Config to full-width

Summary:
Ref T13362. Some applications moved to fixed-width a while ago but I was generally unsatisfied with where they ended up and have been pushing them back to full-width.

Push Config back to full-width. Some of the subpages end up a little weird, but this provides more space to work with to make some improvements, like makign `maniphest.statuses` more legible in the UI>

Test Plan: Grepped for `setFixed(`, updated each page in `/config/`. Browsed each controller, saw workable full-width UIs.

Maniphest Tasks: T13362

Differential Revision: https://secure.phabricator.com/D20925

src/applications/config/controller/PhabricatorConfigAllController.php

@@ -64,13 +64,12 @@ final class PhabricatorConfigAllController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($view);
+      ->setFooter($view);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
 
   }

src/applications/config/controller/PhabricatorConfigApplicationController.php

@@ -18,9 +18,7 @@ final class PhabricatorConfigApplicationController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($apps_list);
+      ->setFooter($apps_list);
 
     $crumbs = $this->buildApplicationCrumbs()
       ->addTextCrumb($title)
@@ -29,6 +27,7 @@ final class PhabricatorConfigApplicationController
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigCacheController.php

@@ -33,13 +33,12 @@ final class PhabricatorConfigCacheController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($page);
+      ->setFooter($page);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

@@ -26,13 +26,12 @@ final class PhabricatorConfigClusterDatabasesController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($status);
+      ->setFooter($status);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

@@ -28,13 +28,12 @@ final class PhabricatorConfigClusterNotificationsController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($status);
+      ->setFooter($status);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

@@ -32,9 +32,8 @@ final class PhabricatorConfigClusterRepositoriesController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn(array(
+      ->setFooter(
+        array(
           $repo_status,
           $repo_errors,
         ));
@@ -42,6 +41,7 @@ final class PhabricatorConfigClusterRepositoriesController
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigClusterSearchController.php

@@ -26,13 +26,12 @@ final class PhabricatorConfigClusterSearchController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($search_status);
+      ->setFooter($search_status);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigController.php

@@ -7,8 +7,6 @@ abstract class PhabricatorConfigController extends PhabricatorController {
   }
 
   public function buildSideNavView($filter = null, $for_app = false) {
-
-
     $guide_href = new PhutilURI('/guides/');
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

@@ -167,13 +167,12 @@ final class PhabricatorConfigDatabaseIssueController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($view);
+      ->setFooter($view);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

@@ -142,13 +142,12 @@ final class PhabricatorConfigDatabaseStatusController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($body);
+      ->setFooter($body);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigEditController.php

@@ -237,9 +237,8 @@ final class PhabricatorConfigEditController
 
     $view = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn(array(
+      ->setFooter(
+        array(
         $error_view,
         $form_box,
         $status_items,
@@ -250,6 +249,7 @@ final class PhabricatorConfigEditController
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($view);
   }
 

src/applications/config/controller/PhabricatorConfigGroupController.php

@@ -36,13 +36,12 @@ final class PhabricatorConfigGroupController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($view);
+      ->setFooter($view);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigHistoryController.php

@@ -36,13 +36,12 @@ final class PhabricatorConfigHistoryController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($timeline);
+      ->setFooter($timeline);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -59,13 +59,12 @@ final class PhabricatorConfigIssueListController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($issue_list);
+      ->setFooter($issue_list);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigIssueViewController.php

@@ -47,13 +47,12 @@ final class PhabricatorConfigIssueViewController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($content);
+      ->setFooter($content);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigListController.php

@@ -22,13 +22,12 @@ final class PhabricatorConfigListController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($core_list);
+      ->setFooter($core_list);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigModuleController.php

@@ -28,13 +28,12 @@ final class PhabricatorConfigModuleController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($view);
+      ->setFooter($view);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
   }
 

src/applications/config/controller/PhabricatorConfigVersionController.php

@@ -23,15 +23,13 @@ final class PhabricatorConfigVersionController
 
     $content = id(new PHUITwoColumnView())
       ->setHeader($header)
-      ->setNavigation($nav)
-      ->setFixed(true)
-      ->setMainColumn($view);
+      ->setFooter($view);
 
     return $this->newPage()
       ->setTitle($title)
       ->setCrumbs($crumbs)
+      ->setNavigation($nav)
       ->appendChild($content);
-
   }
 
   public function renderModuleStatus($viewer) {