revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
Code Issues Releases Wiki Activity

Extend Config to full-width

Browse source 
Summary:
Ref T13362. Some applications moved to fixed-width a while ago but I was generally unsatisfied with where they ended up and have been pushing them back to full-width.

Push Config back to full-width. Some of the subpages end up a little weird, but this provides more space to work with to make some improvements, like makign `maniphest.statuses` more legible in the UI>

Test Plan: Grepped for `setFixed(`, updated each page in `/config/`. Browsed each controller, saw workable full-width UIs.

Maniphest Tasks: T13362

Differential Revision: https://secure.phabricator.com/D20925
This commit is contained in:
epriestley 2019-11-25 14:34:32 -08:00
parent 1667acfa5d
commit 33c534f9b7
18 changed files with 39 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/config/controller/PhabricatorConfigAllController.php
View file

@ -64,13 +64,12 @@ final class PhabricatorConfigAllController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($view);
->setFooter($view);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigApplicationController.php
View file

@ -18,9 +18,7 @@ final class PhabricatorConfigApplicationController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($apps_list);
->setFooter($apps_list);
$crumbs = $this->buildApplicationCrumbs()
->addTextCrumb($title)
@ -29,6 +27,7 @@ final class PhabricatorConfigApplicationController
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigCacheController.php
View file

@ -33,13 +33,12 @@ final class PhabricatorConfigCacheController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($page);
->setFooter($page);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php
View file

@ -26,13 +26,12 @@ final class PhabricatorConfigClusterDatabasesController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($status);
->setFooter($status);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php
View file

@ -28,13 +28,12 @@ final class PhabricatorConfigClusterNotificationsController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($status);
->setFooter($status);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

12
src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php
View file

@ -32,16 +32,16 @@ final class PhabricatorConfigClusterRepositoriesController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn(array(
$repo_status,
$repo_errors,
));
->setFooter(
array(
$repo_status,
$repo_errors,
));
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigClusterSearchController.php
View file

@ -26,13 +26,12 @@ final class PhabricatorConfigClusterSearchController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($search_status);
->setFooter($search_status);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

2
src/applications/config/controller/PhabricatorConfigController.php
View file

@ -7,8 +7,6 @@ abstract class PhabricatorConfigController extends PhabricatorController {
}
public function buildSideNavView($filter = null, $for_app = false) {
$guide_href = new PhutilURI('/guides/');
$nav = new AphrontSideNavFilterView();
$nav->setBaseURI(new PhutilURI($this->getApplicationURI()));

5
src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
View file

@ -167,13 +167,12 @@ final class PhabricatorConfigDatabaseIssueController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($view);
->setFooter($view);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
View file

@ -142,13 +142,12 @@ final class PhabricatorConfigDatabaseStatusController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($body);
->setFooter($body);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

6
src/applications/config/controller/PhabricatorConfigEditController.php
View file

@ -237,9 +237,8 @@ final class PhabricatorConfigEditController
$view = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn(array(
->setFooter(
array(
$error_view,
$form_box,
$status_items,
@ -250,6 +249,7 @@ final class PhabricatorConfigEditController
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($view);
}

5
src/applications/config/controller/PhabricatorConfigGroupController.php
View file

@ -36,13 +36,12 @@ final class PhabricatorConfigGroupController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($view);
->setFooter($view);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigHistoryController.php
View file

@ -36,13 +36,12 @@ final class PhabricatorConfigHistoryController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($timeline);
->setFooter($timeline);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigIssueListController.php
View file

@ -59,13 +59,12 @@ final class PhabricatorConfigIssueListController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($issue_list);
->setFooter($issue_list);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigIssueViewController.php
View file

@ -47,13 +47,12 @@ final class PhabricatorConfigIssueViewController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($content);
->setFooter($content);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigListController.php
View file

@ -22,13 +22,12 @@ final class PhabricatorConfigListController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($core_list);
->setFooter($core_list);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

5
src/applications/config/controller/PhabricatorConfigModuleController.php
View file

@ -28,13 +28,12 @@ final class PhabricatorConfigModuleController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($view);
->setFooter($view);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}

6
src/applications/config/controller/PhabricatorConfigVersionController.php
View file

@ -23,15 +23,13 @@ final class PhabricatorConfigVersionController
$content = id(new PHUITwoColumnView())
->setHeader($header)
->setNavigation($nav)
->setFixed(true)
->setMainColumn($view);
->setFooter($view);
return $this->newPage()
->setTitle($title)
->setCrumbs($crumbs)
->setNavigation($nav)
->appendChild($content);
}
public function renderModuleStatus($viewer) {