revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-15 01:50:55 +01:00
Code Issues Releases Wiki Activity

(stable) Always show "X requested review" in mail to stop some undraft mail from being dropped

Browse source 
Summary: Ref T13035. See that task for a description of the issue.

Test Plan:
  - Enabled prototypes.
  - Disabled all Herald rules that trigger Harbormaster builds.
  - Created a new revision.
  - Before patch: initial review request email was dropped.
  - After patch: initial review request email is sent.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13035

Differential Revision: https://secure.phabricator.com/D18851
This commit is contained in:
epriestley 2018-01-03 13:40:44 -08:00
parent 65fa04754a
commit 33f7f65e81
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/storage/DifferentialTransaction.php
View file

@ -111,6 +111,12 @@ final class DifferentialTransaction
// Don't hide the initial "X added reviewers: ..." transaction during
// object creation from mail. See T12118 and PHI54.
return false;
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
// Don't hide the initial "X requested review: ..." transaction from
// mail even when it occurs during creation. We need this transaction
// to survive so we'll generate mail when revisions immediately leave
// the draft state. See T13035 for discussion.
return false;
}
return parent::shouldHideForMail($xactions);