From 34076fae38f94285377757b15ff11dff287c8aa0 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 18 Jan 2013 18:08:06 -0800 Subject: [PATCH] Config style updates. Summary: Minor spacing tweaks to Config app. Added label for consistency. Test Plan: Review pages in the Config app for spacing. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4523 --- src/__celerity_resource_map__.php | 82 +++++++++---------- .../PhabricatorConfigAllController.php | 6 +- .../PhabricatorConfigController.php | 1 + .../phabricator-object-item-list-view.css | 8 ++ 4 files changed, 55 insertions(+), 42 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 9bd004087d..483ac2189a 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -2666,7 +2666,7 @@ celerity_register_resource_map(array( ), 'phabricator-object-item-list-view-css' => array( - 'uri' => '/res/8ae43833/rsrc/css/layout/phabricator-object-item-list-view.css', + 'uri' => '/res/1f9c7ebb/rsrc/css/layout/phabricator-object-item-list-view.css', 'type' => 'css', 'requires' => array( @@ -3229,7 +3229,7 @@ celerity_register_resource_map(array( ), array( 'packages' => array( - 'dc3c0d8e' => + '7e7a7582' => array( 'name' => 'core.pkg.css', 'symbols' => @@ -3273,7 +3273,7 @@ celerity_register_resource_map(array( 36 => 'phabricator-object-item-list-view-css', 37 => 'global-drag-and-drop-css', ), - 'uri' => '/res/pkg/dc3c0d8e/core.pkg.css', + 'uri' => '/res/pkg/7e7a7582/core.pkg.css', 'type' => 'css', ), 'c90b892e' => @@ -3463,19 +3463,19 @@ celerity_register_resource_map(array( 'reverse' => array( 'aphront-attached-file-view-css' => 'a88951d1', - 'aphront-crumbs-view-css' => 'dc3c0d8e', - 'aphront-dialog-view-css' => 'dc3c0d8e', - 'aphront-error-view-css' => 'dc3c0d8e', - 'aphront-form-view-css' => 'dc3c0d8e', + 'aphront-crumbs-view-css' => '7e7a7582', + 'aphront-dialog-view-css' => '7e7a7582', + 'aphront-error-view-css' => '7e7a7582', + 'aphront-form-view-css' => '7e7a7582', 'aphront-headsup-action-list-view-css' => 'ec01d039', - 'aphront-headsup-view-css' => 'dc3c0d8e', - 'aphront-list-filter-view-css' => 'dc3c0d8e', - 'aphront-pager-view-css' => 'dc3c0d8e', - 'aphront-panel-view-css' => 'dc3c0d8e', - 'aphront-table-view-css' => 'dc3c0d8e', - 'aphront-tokenizer-control-css' => 'dc3c0d8e', - 'aphront-tooltip-css' => 'dc3c0d8e', - 'aphront-typeahead-control-css' => 'dc3c0d8e', + 'aphront-headsup-view-css' => '7e7a7582', + 'aphront-list-filter-view-css' => '7e7a7582', + 'aphront-pager-view-css' => '7e7a7582', + 'aphront-panel-view-css' => '7e7a7582', + 'aphront-table-view-css' => '7e7a7582', + 'aphront-tokenizer-control-css' => '7e7a7582', + 'aphront-tooltip-css' => '7e7a7582', + 'aphront-typeahead-control-css' => '7e7a7582', 'differential-changeset-view-css' => 'ec01d039', 'differential-core-view-css' => 'ec01d039', 'differential-inline-comment-editor' => 'ac53d36a', @@ -3489,7 +3489,7 @@ celerity_register_resource_map(array( 'differential-table-of-contents-css' => 'ec01d039', 'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88', - 'global-drag-and-drop-css' => 'dc3c0d8e', + 'global-drag-and-drop-css' => '7e7a7582', 'inline-comment-summary-css' => 'ec01d039', 'javelin-aphlict' => 'c90b892e', 'javelin-behavior' => 'fbeded59', @@ -3559,48 +3559,48 @@ celerity_register_resource_map(array( 'javelin-util' => 'fbeded59', 'javelin-vector' => 'fbeded59', 'javelin-workflow' => 'fbeded59', - 'lightbox-attachment-css' => 'dc3c0d8e', + 'lightbox-attachment-css' => '7e7a7582', 'maniphest-task-summary-css' => 'a88951d1', 'maniphest-transaction-detail-css' => 'a88951d1', 'phabricator-busy' => 'c90b892e', 'phabricator-content-source-view-css' => 'ec01d039', - 'phabricator-core-buttons-css' => 'dc3c0d8e', - 'phabricator-core-css' => 'dc3c0d8e', - 'phabricator-crumbs-view-css' => 'dc3c0d8e', - 'phabricator-directory-css' => 'dc3c0d8e', + 'phabricator-core-buttons-css' => '7e7a7582', + 'phabricator-core-css' => '7e7a7582', + 'phabricator-crumbs-view-css' => '7e7a7582', + 'phabricator-directory-css' => '7e7a7582', 'phabricator-drag-and-drop-file-upload' => 'ac53d36a', 'phabricator-dropdown-menu' => 'c90b892e', 'phabricator-file-upload' => 'c90b892e', - 'phabricator-filetree-view-css' => 'dc3c0d8e', - 'phabricator-flag-css' => 'dc3c0d8e', - 'phabricator-form-view-css' => 'dc3c0d8e', - 'phabricator-header-view-css' => 'dc3c0d8e', - 'phabricator-jump-nav' => 'dc3c0d8e', + 'phabricator-filetree-view-css' => '7e7a7582', + 'phabricator-flag-css' => '7e7a7582', + 'phabricator-form-view-css' => '7e7a7582', + 'phabricator-header-view-css' => '7e7a7582', + 'phabricator-jump-nav' => '7e7a7582', 'phabricator-keyboard-shortcut' => 'c90b892e', 'phabricator-keyboard-shortcut-manager' => 'c90b892e', - 'phabricator-main-menu-view' => 'dc3c0d8e', + 'phabricator-main-menu-view' => '7e7a7582', 'phabricator-menu-item' => 'c90b892e', - 'phabricator-nav-view-css' => 'dc3c0d8e', + 'phabricator-nav-view-css' => '7e7a7582', 'phabricator-notification' => 'c90b892e', - 'phabricator-notification-css' => 'dc3c0d8e', - 'phabricator-notification-menu-css' => 'dc3c0d8e', - 'phabricator-object-item-list-view-css' => 'dc3c0d8e', + 'phabricator-notification-css' => '7e7a7582', + 'phabricator-notification-menu-css' => '7e7a7582', + 'phabricator-object-item-list-view-css' => '7e7a7582', 'phabricator-object-selector-css' => 'ec01d039', 'phabricator-paste-file-upload' => 'c90b892e', 'phabricator-prefab' => 'c90b892e', 'phabricator-project-tag-css' => 'a88951d1', - 'phabricator-remarkup-css' => 'dc3c0d8e', + 'phabricator-remarkup-css' => '7e7a7582', 'phabricator-shaped-request' => 'ac53d36a', - 'phabricator-side-menu-view-css' => 'dc3c0d8e', - 'phabricator-standard-page-view' => 'dc3c0d8e', + 'phabricator-side-menu-view-css' => '7e7a7582', + 'phabricator-standard-page-view' => '7e7a7582', 'phabricator-textareautils' => 'c90b892e', 'phabricator-tooltip' => 'c90b892e', - 'phabricator-transaction-view-css' => 'dc3c0d8e', - 'phabricator-zindex-css' => 'dc3c0d8e', - 'sprite-apps-large-css' => 'dc3c0d8e', - 'sprite-gradient-css' => 'dc3c0d8e', - 'sprite-icon-css' => 'dc3c0d8e', - 'sprite-menu-css' => 'dc3c0d8e', - 'syntax-highlighting-css' => 'dc3c0d8e', + 'phabricator-transaction-view-css' => '7e7a7582', + 'phabricator-zindex-css' => '7e7a7582', + 'sprite-apps-large-css' => '7e7a7582', + 'sprite-gradient-css' => '7e7a7582', + 'sprite-icon-css' => '7e7a7582', + 'sprite-menu-css' => '7e7a7582', + 'syntax-highlighting-css' => '7e7a7582', ), )); diff --git a/src/applications/config/controller/PhabricatorConfigAllController.php b/src/applications/config/controller/PhabricatorConfigAllController.php index 81b32c226b..1ed9b2b799 100644 --- a/src/applications/config/controller/PhabricatorConfigAllController.php +++ b/src/applications/config/controller/PhabricatorConfigAllController.php @@ -54,10 +54,14 @@ final class PhabricatorConfigAllController id(new PhabricatorCrumbView()) ->setName($title)); + $panel = new AphrontPanelView(); + $panel->appendChild($table); + $panel->setNoBackground(); + $nav = $this->buildSideNavView(); $nav->selectFilter('all/'); $nav->setCrumbs($crumbs); - $nav->appendChild($table); + $nav->appendChild($panel); return $this->buildApplicationPage( $nav, diff --git a/src/applications/config/controller/PhabricatorConfigController.php b/src/applications/config/controller/PhabricatorConfigController.php index e8c7d1eb22..c43a3d60f8 100644 --- a/src/applications/config/controller/PhabricatorConfigController.php +++ b/src/applications/config/controller/PhabricatorConfigController.php @@ -11,6 +11,7 @@ abstract class PhabricatorConfigController extends PhabricatorController { $nav = new AphrontSideNavFilterView(); $nav->setBaseURI(new PhutilURI($this->getApplicationURI())); + $nav->addLabel(pht('Site Config')); $nav->addFilter('/', pht('Configuration')); $nav->addFilter('issue/', pht('Setup Issues')); $nav->addFilter('all/', pht('Current Settings')); diff --git a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css index fe33ddab1c..25c01eabb6 100644 --- a/webroot/rsrc/css/layout/phabricator-object-item-list-view.css +++ b/webroot/rsrc/css/layout/phabricator-object-item-list-view.css @@ -7,6 +7,10 @@ background: #f4f5f6; } +.device-desktop .phabricator-object-item-list-view { + padding: 20px; +} + .phabricator-object-item { background: #ffffff; border-style: solid; @@ -18,6 +22,10 @@ box-shadow: 0px 1px 1px rgba(0, 0, 0, 0.10); } +.device-desktop .phabricator-object-item { + margin: 0 0 5px 0; +} + .phabricator-object-item-name { display: block; padding: 4px 8px 4px;