From 3574a55a95bda7d852dacd3082bfa312d610f615 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 2 Aug 2018 16:33:41 -0700 Subject: [PATCH] Deprecate Conduit method "diffusion.getrecentcommitsbypath" Summary: See D19558. This method has no callers and just wraps `diffusion.historyquery`, since D5960 (2013). This was introduced in D315 (which didn't make it out of FB, I think) inside Facebook for unclear purposes in 2011. Test Plan: Grepped for callers, found none. Reviewers: amckinley Reviewed By: amckinley Subscribers: artms Differential Revision: https://secure.phabricator.com/D19559 --- .../DiffusionGetRecentCommitsByPathConduitAPIMethod.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php index 65bc5f69da..286831f82b 100644 --- a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php +++ b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php @@ -9,6 +9,14 @@ final class DiffusionGetRecentCommitsByPathConduitAPIMethod return 'diffusion.getrecentcommitsbypath'; } + public function getMethodStatus() { + return self::METHOD_STATUS_DEPRECATED; + } + + public function getMethodStatusDescription() { + return pht('Obsoleted by "diffusion.historyquery".'); + } + public function getMethodDescription() { return pht( 'Get commit identifiers for recent commits affecting a given path.');