From 360ebce00fe88fee0aa132092467116eacaf35af Mon Sep 17 00:00:00 2001 From: Marc Lindenberg Date: Mon, 14 Jan 2019 09:41:31 -0800 Subject: [PATCH] call qsprintf() without warnings Summary: After T13217 import_repository_symbols.php was showing a lot of warnings, using %LQ fixes that. I'm aware, that there are changes planned to the whole managing the symbols complex but until then less warnings are nice. Test Plan: No more warnings when updating symbols Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D19962 --- scripts/symbols/import_repository_symbols.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/symbols/import_repository_symbols.php b/scripts/symbols/import_repository_symbols.php index b84aea3485..24a0624d64 100755 --- a/scripts/symbols/import_repository_symbols.php +++ b/scripts/symbols/import_repository_symbols.php @@ -110,9 +110,9 @@ function commit_symbols( $conn_w, 'INSERT INTO %T (repositoryPHID, symbolContext, symbolName, symbolType, - symbolLanguage, lineNumber, pathID) VALUES %Q', + symbolLanguage, lineNumber, pathID) VALUES %LQ', $symbol->getTableName(), - implode(', ', $chunk)); + $chunk); } }