revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-31 18:01:00 +01:00
Code Issues Releases Wiki Activity

Dark description tweaks for Pholio.

Browse source 
Summary: Uses a dark description area and white text for pholio mocks. Also touches up the borders a little bit.

Test Plan: review pholio, files, and macros for visual changes intended or not.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5143
This commit is contained in:
Chad Little 2013-02-27 20:10:30 -08:00
parent 88497bf7df
commit 362511c3ae
5 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/__celerity_resource_map__.php
View file

@ -2924,7 +2924,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-property-list-view-css' => 'phabricator-property-list-view-css' =>
array( array(
'uri' => '/res/dfee0687/rsrc/css/layout/phabricator-property-list-view.css', 'uri' => '/res/a04cc81d/rsrc/css/layout/phabricator-property-list-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3218,7 +3218,7 @@ celerity_register_resource_map(array(
), ),
'pholio-css' => 'pholio-css' =>
array( array(
'uri' => '/res/4ca7889f/rsrc/css/application/pholio/pholio.css', 'uri' => '/res/5cff78f4/rsrc/css/application/pholio/pholio.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(

2
src/applications/pholio/controller/PholioMockViewController.php
View file

@ -170,7 +170,7 @@ final class PholioMockViewController extends PholioController {
$properties->invokeWillRenderEvent(); $properties->invokeWillRenderEvent();
$properties->addTextContent( $properties->addImageContent(
$engine->getOutput($mock, PholioMock::MARKUP_FIELD_DESCRIPTION)); $engine->getOutput($mock, PholioMock::MARKUP_FIELD_DESCRIPTION));
return $properties; return $properties;

8
src/applications/pholio/storage/PholioMock.php
View file

@ -113,7 +113,13 @@ final class PholioMock extends PholioDAO
} }
public function getMarkupText($field) { public function getMarkupText($field) {
return $this->getDescription(); if ($this->getDescription()) {
$description = $this->getDescription();
} else {
$description = pht('No Description Given');
}
return $description;
} }
public function didMarkupText($field, $output, PhutilMarkupEngine $engine) { public function didMarkupText($field, $output, PhutilMarkupEngine $engine) {

5
webroot/rsrc/css/application/pholio/pholio.css
View file

@ -59,7 +59,9 @@
.pholio-mock-image-panel { .pholio-mock-image-panel {
padding: 20px; padding: 20px;
margin-right: 320px; margin-right: 319px;
border-top: 1px solid #333;
border-right: 1px solid #333;
} }
.pholio-mock-image-viewport { .pholio-mock-image-viewport {
@ -71,6 +73,7 @@
.pholio-mock-inline-comments { .pholio-mock-inline-comments {
width: 320px; width: 320px;
border-left: 1px solid #101010; border-left: 1px solid #101010;
border-top: 1px solid #333;
position: absolute; position: absolute;
top: 0; top: 0;
bottom: 0; bottom: 0;

2
webroot/rsrc/css/layout/phabricator-property-list-view.css
View file

@ -95,6 +95,8 @@
.phabricator-property-list-image-content { .phabricator-property-list-image-content {
background: #282828; background: #282828;
border-color: #101010;
color: #fff;
} }