revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Delete some commit dead parsing code

Browse source 
Summary: Ref T13552. Neither "$hashes" or "$user" are used, and constructing them has no side effects.

Test Plan: Searched for these symbols.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21441
This commit is contained in:
epriestley 2020-08-12 09:29:52 -07:00
parent 3dfa89dd5d
commit 367cd28927
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
View file

@ -63,7 +63,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$commit = $this->commit; $commit = $this->commit;
$author = $ref->getAuthor(); $author = $ref->getAuthor();
$committer = $ref->getCommitter(); $committer = $ref->getCommitter();
$hashes = $ref->getHashes();
$has_committer = (bool)strlen($committer); $has_committer = (bool)strlen($committer);
$viewer = PhabricatorUser::getOmnipotentUser(); $viewer = PhabricatorUser::getOmnipotentUser();
@ -137,13 +136,6 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$author_phid = $data->getCommitDetail('authorPHID'); $author_phid = $data->getCommitDetail('authorPHID');
$committer_phid = $data->getCommitDetail('committerPHID'); $committer_phid = $data->getCommitDetail('committerPHID');
$user = new PhabricatorUser();
if ($author_phid) {
$user = $user->loadOneWhere(
'phid = %s',
$author_phid);
}
if ($author_phid != $commit->getAuthorPHID()) { if ($author_phid != $commit->getAuthorPHID()) {
$commit->setAuthorPHID($author_phid); $commit->setAuthorPHID($author_phid);
} }