revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Minor tweaks to pre/inline style for inline comments in HTML mail

Browse source 
Summary:
Ref T10694.

  - Shift margins/padding around so inlines with multiple paragraphs get reasonable spacing.
  - Add `text-decoration: none` to the "View Inline" link to kill the underline.

Test Plan: {F1265342}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10694

Differential Revision: https://secure.phabricator.com/D15863
This commit is contained in:
epriestley 2016-05-06 10:48:16 -07:00
parent 053d6111e4
commit 371051ff37
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -1385,7 +1385,17 @@ final class DifferentialTransactionEditor
$header = pht('INLINE COMMENTS'); $header = pht('INLINE COMMENTS');
$section_text = "\n".$section->getPlaintext(); $section_text = "\n".$section->getPlaintext();
$section_html = $section->getHTML();
$style = array(
'margin: 12px 0;',
);
$section_html = phutil_tag(
'div',
array(
'style' => implode(' ', $style),
),
$section->getHTML());
$body->addPlaintextSection($header, $section_text, false); $body->addPlaintextSection($header, $section_text, false);
$body->addHTMLSection($header, $section_html); $body->addHTMLSection($header, $section_html);

8
src/applications/differential/mail/DifferentialInlineCommentMailView.php
View file

@ -201,7 +201,8 @@ final class DifferentialInlineCommentMailView
if ($is_html) { if ($is_html) {
$style = array( $style = array(
'padding: 8px 12px;', 'margin: 8px 0;',
'padding: 0 12px;',
); );
if ($is_quote) { if ($is_quote) {
@ -249,7 +250,7 @@ final class DifferentialInlineCommentMailView
} }
$attributes = array( $attributes = array(
'style' => 'padding: 0; margin: 0;', 'style' => 'padding: 0; margin: 8px;',
); );
$engine = PhabricatorMarkupEngine::newMarkupEngine(array()) $engine = PhabricatorMarkupEngine::newMarkupEngine(array())
@ -461,6 +462,7 @@ final class DifferentialInlineCommentMailView
if ($link_href) { if ($link_href) {
$link_style = array( $link_style = array(
'float: right;', 'float: right;',
'text-decoration: none;',
); );
$link = phutil_tag( $link = phutil_tag(
@ -477,7 +479,7 @@ final class DifferentialInlineCommentMailView
$style = array( $style = array(
'color: #74777d;', 'color: #74777d;',
'background: #eff2f4;', 'background: #eff2f4;',
'padding: 4px 8px;', 'padding: 6px 8px;',
'overflow: hidden;', 'overflow: hidden;',
); );